avm2: Store PerspectiveProjection to DisplayObject #19670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookie-s
force-pushed
the
perspective-projection-storage
branch
6 times, most recently
from
3d16d8c to
19168c2
Compare
Stage and root have their own initial PerspectiveProjection value, and it's also used when attempting to set `null`.
* Remove FIXME for TestTranformUpdate() * Add four more test cases
It's now unused because ruffle_render::Transform stores Option<PerspectiveProjection>.
It's very hard to verify this value with any test while PerspectiveProjection rendering is not implemented. However, this change makes the most sense.
cookie-s
force-pushed
the
perspective-projection-storage
branch
from
19168c2 to
af96e50
Compare
Lord-McSweeney
added
A-avm2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #19532 .
DisplayObject stores
Option<PerspectiveProjection>throughTransformso we can removeHAS_PERSPECTIVE_PROJECTION_STUBflag from display objects.The test
from_shumway/avm2/flash/geom/perspectiveprojectionpasses now.Limitation
PerspectiveProjection is stored in Transform, but it's not used in rendering at all. (Hence, we cannot remove
stub_setters)