impl: parse_and_output_manpages #96

charliethomson · 2020-07-13T03:46:41Z

No description provided.

Cargo.toml

src/main.rs

Co-authored-by: Ivan Tham <pickfire@riseup.net>

…com/charliethomson/fish-manpage-completions into parse_and_output_manpages_fixed

Co-authored-by: Ivan Tham <pickfire@riseup.net>

src/main.rs

…com/charliethomson/fish-manpage-completions into parse_and_output_manpages_fixed

src/main.rs

Co-authored-by: Ivan Tham <pickfire@riseup.net>

src/main.rs

Co-authored-by: Ivan Tham <pickfire@riseup.net>

pickfire

Looks good to me.

pickfire · 2020-08-01T09:20:52Z

@charliethomson You are correct, the panic I suggested was incorrect, I didn't test it correct. Sorry about the bad suggestion, can you please revert it? Once it is reverted I can merge this.

charliethomson · 2020-08-01T12:39:36Z

@pickfire

charliethomson added 2 commits July 12, 2020 23:45

impl: parse_and_output_manpages

696a2fd

oops, fix my bad code lol

9617c78

scooter-dangle reviewed Jul 13, 2020

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

scooter-dangle reviewed Jul 13, 2020

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

fixup! 9617c78

eca4937

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 13, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

charliethomson and others added 10 commits July 14, 2020 10:55

add_diagnostic comment to function

f678924

Co-authored-by: Ivan Tham <pickfire@riseup.net>

P -> PathBuf, diag for IOError

1f0458c

Merge branch 'parse_and_output_manpages_fixed' of https://www.github.…

855c774

…com/charliethomson/fish-manpage-completions into parse_and_output_manpages_fixed

and_then for cmd_name

da160a2

rust fmt string padding

1f7b988

Co-authored-by: Ivan Tham <pickfire@riseup.net>

fix the format string

a87d53b

fix the format string again

f67aa76

Minor reformat, add num_digits, use fmt padding again

57c0602

Remove return statements

00daf5e

Remove python

711fc9e

pickfire reviewed Jul 14, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 14, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

fixup!

34857c9

scooter-dangle reviewed Jul 21, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

scooter-dangle reviewed Jul 21, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

scooter-dangle reviewed Jul 21, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 21, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 21, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

charliethomson added 4 commits July 21, 2020 03:16

remove resolved todos

ca4569f

Merge branch 'parse_and_output_manpages_fixed' of https://www.github.…

beeda3a

…com/charliethomson/fish-manpage-completions into parse_and_output_manpages_fixed

Remove comment about xz/lzma, not relevant to this port, we support them

d8e1d8e

pickfire, fancy \r

10a0120

charliethomson requested review from scooter-dangle and pickfire July 22, 2020 18:13

pickfire reviewed Jul 23, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 23, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 23, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 23, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

pickfire reviewed Jul 23, 2020

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

charliethomson and others added 6 commits July 24, 2020 16:16

Remove one line of whitespace

4f22c2c

Co-authored-by: Ivan Tham <pickfire@riseup.net>

as_ref()

8ae866d

Co-authored-by: Ivan Tham <pickfire@riseup.net>

as_ref() part 2

c72ad4d

Co-authored-by: Ivan Tham <pickfire@riseup.net>

deas_ref, max_digits, remove initial spaces from

59d309a

remove last_len, padding; use progress instead

69bca77

Use display

5cae975

pickfire reviewed Jul 26, 2020

View reviewed changes

src/main.rs Show resolved Hide resolved

panic! one line

40df153

Co-authored-by: Ivan Tham <pickfire@riseup.net>

pickfire approved these changes Aug 1, 2020

View reviewed changes

revert

96db160

pickfire merged commit 9e57acf into rust-dc:master Aug 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

impl: parse_and_output_manpages #96

impl: parse_and_output_manpages #96

charliethomson commented Jul 13, 2020

pickfire left a comment

pickfire commented Aug 1, 2020

charliethomson commented Aug 1, 2020

impl: parse_and_output_manpages #96

impl: parse_and_output_manpages #96

Conversation

charliethomson commented Jul 13, 2020

pickfire left a comment

Choose a reason for hiding this comment

pickfire commented Aug 1, 2020

charliethomson commented Aug 1, 2020