Skip to content

Commit

Permalink
Unrolled build for rust-lang#137451
Browse files Browse the repository at this point in the history
Rollup merge of rust-lang#137451 - compiler-errors:synm, r=Noratrieb

FIx `sym` -> `syn` typo in tail-expr-drop-order type opt-out

The rust-lang#131326 PR attempts to reduce some false positives for the `tail_expr_drop_order` lint by hard-coding some common ecosystem crate names. Specifically, I believe it attempts to opt out the drop impls from `syn` which only exist as optimizations.

However, this was typo'd like "sym", which is a crate that has been [yanked](https://crates.io/crates/sym) (lol). This PR fixes that.

cc `@dingxiangfei2009` `@nikomatsakis` -- did I mistake this? Was this meant to be a different crate?

`@bors` rollup
  • Loading branch information
rust-timer authored Feb 24, 2025
2 parents f8a913b + 506532a commit 831d9c6
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ fn true_significant_drop_ty<'tcx>(
debug!(?name_str);
match name_str[..] {
// These are the types from Rust core ecosystem
["sym" | "proc_macro2", ..]
["syn" | "proc_macro2", ..]
| ["core" | "std", "task", "LocalWaker" | "Waker"]
| ["core" | "std", "task", "wake", "LocalWaker" | "Waker"] => Some(smallvec![]),
// These are important types from Rust ecosystem
Expand Down

0 comments on commit 831d9c6

Please sign in to comment.