-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish up Miri integration #376
Conversation
@alexcrichton: How do you want to handle the case where Miri is not available for a given channel? |
Thanks for this! Could a new CI builder be added with a pinned nightly version to handle drift in miri? |
@RalfJung What's the preferred way to handle this kind of thing? Is there a way to get Rustup to automatically install the most recent nightly that has Miri available? |
Yes, it is described in our README:
|
@alexcrichton: This should be ready to merge |
👍 |
This pulls in rust-lang/backtrace-rs#376, which fixes Miri support for `std::backtrace::Backtrace`.
…ark-Simulacrum Bump backtrace-rs This pulls in rust-lang/backtrace-rs#376, which fixes Miri support for `std::backtrace::Backtrace`.
…ark-Simulacrum Bump backtrace-rs This pulls in rust-lang/backtrace-rs#376, which fixes Miri support for `std::backtrace::Backtrace`.
…ark-Simulacrum Bump backtrace-rs This pulls in rust-lang/backtrace-rs#376, which fixes Miri support for `std::backtrace::Backtrace`.
This PR gets all of the tests passing under Miri, and runs them on CI.