Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace yaml with toml front matter #1508

Merged
merged 5 commits into from
Mar 8, 2025
Merged

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Mar 8, 2025

I snapshot tested this locally, the output should be identical. One commit contains the changes to the header of every post, which is a big, scripted diff. I also snuck in an unrelated change by fixing the windows line endings on a few posts, which looks like the entire file was changed. The other commits have a more readable diff.

Rendered

@senekor senekor requested a review from Manishearth March 8, 2025 11:00
@senekor
Copy link
Contributor Author

senekor commented Mar 8, 2025

A tiny regression seems to be that the preview rendered by triagebot doesn't look the same. Yaml front matter results in a nice table while toml front matter is left as-is.

Edit: Not related to triagebot, this is just how GitHub renders its markdown. I don't think we can do anything about this.

@senekor senekor mentioned this pull request Mar 8, 2025
@senekor senekor force-pushed the senekor/toml-front-matter branch from 6bae729 to 6e6d05f Compare March 8, 2025 19:23
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought: What if we had a CI job that ran snapshot tests against the merge-base or trunk IF the PR body had "RUN_SNAPSHOT_TESTS" in it?

@Manishearth Manishearth merged commit c4ae3d4 into master Mar 8, 2025
3 checks passed
@Manishearth Manishearth deleted the senekor/toml-front-matter branch March 8, 2025 23:53
@senekor
Copy link
Contributor Author

senekor commented Mar 8, 2025

Great idea! Opened an issue for it so I don't forget :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants