Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo install panics when trying to install multiple binaries from git: 'BUG: update() must be called before query()' #6059

Closed
ghost opened this issue Sep 20, 2018 · 0 comments · Fixed by #6060
Assignees

Comments

@ghost
Copy link

ghost commented Sep 20, 2018

I am trying to use cargo install to install multiple binary crates from a git repository, using the command line cargo install --git file:///home/bram.senders/source/cargo-install-test bin1 bin2. After having installed the first binary, Cargo panics with thread 'main' panicked at 'BUG: update() must be called before query()', libcore/option.rs:989:5.

I tried this (this is a minimal example using a git file:/// URL, my actual use case uses ssh:/// URLs to a private repository):

bram.senders@lcdesktop-08 ~/source/cargo-install-test> cat Cargo.toml 
[workspace]
members = ["bin1", "bin2"]

bram.senders@lcdesktop-08 ~/source/cargo-install-test> cat bin1/src/main.rs 
fn main() {
    println!("Hello, world!");
}

bram.senders@lcdesktop-08 ~/source/cargo-install-test> cat bin2/src/main.rs 
fn main() {
    println!("Hello, world!");
}

bram.senders@lcdesktop-08 ~> cargo install --git file:///home/bram.senders/source/cargo-install-test bin1 bin2
    Updating git repository `file:///home/bram.senders/source/cargo-install-test`
  Installing bin1 v0.1.0 (file:///home/bram.senders/source/cargo-install-test#697b99ee)                  
   Compiling bin1 v0.1.0 (file:///home/bram.senders/source/cargo-install-test#697b99ee)                  
    Finished release [optimized] target(s) in 0.29s
  Installing /home/bram.senders/.cargo/bin/bin1
thread 'main' panicked at 'BUG: update() must be called before query()', libcore/option.rs:989:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

bram.senders@lcdesktop-08 ~> RUST_BACKTRACE=1 cargo install --force --git file:///home/bram.senders/source/cargo-install-test bin1 bin2
    Updating git repository `file:///home/bram.senders/source/cargo-install-test`
  Installing bin1 v0.1.0 (file:///home/bram.senders/source/cargo-install-test#697b99ee)                  
   Compiling bin1 v0.1.0 (file:///home/bram.senders/source/cargo-install-test#697b99ee)                  
    Finished release [optimized] target(s) in 0.30s
   Replacing /home/bram.senders/.cargo/bin/bin1
thread 'main' panicked at 'BUG: update() must be called before query()', libcore/option.rs:989:5
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::print
             at libstd/sys_common/backtrace.rs:71
             at libstd/sys_common/backtrace.rs:59
   2: std::panicking::default_hook::{{closure}}
             at libstd/panicking.rs:211
   3: std::panicking::default_hook
             at libstd/panicking.rs:227
   4: std::panicking::rust_panic_with_hook
             at libstd/panicking.rs:475
   5: std::panicking::continue_panic_fmt
             at libstd/panicking.rs:390
   6: rust_begin_unwind
             at libstd/panicking.rs:325
   7: core::panicking::panic_fmt
             at libcore/panicking.rs:77
   8: core::option::expect_failed
             at libcore/option.rs:989
   9: cargo::core::source::Source::query_vec
  10: cargo::ops::cargo_install::install_one
  11: cargo::ops::cargo_install::install
  12: cargo::commands::install::exec
  13: cargo::cli::main
  14: cargo::main
  15: std::rt::lang_start::{{closure}}
  16: std::panicking::try::do_call
             at libstd/rt.rs:59
             at libstd/panicking.rs:310
  17: __rust_maybe_catch_panic
             at libpanic_unwind/lib.rs:105
  18: std::rt::lang_start_internal
             at libstd/panicking.rs:289
             at libstd/panic.rs:392
             at libstd/rt.rs:58
  19: main
  20: __libc_start_main
  21: <unknown>

bram.senders@lcdesktop-08 ~> echo $?
101

Installing the binaries one by one does work:

bram.senders@lcdesktop-08 ~> cargo install --force --git file:///home/bram.senders/source/cargo-install-test bin1      
    Updating git repository `file:///home/bram.senders/source/cargo-install-test`
  Installing bin1 v0.1.0 (file:///home/bram.senders/source/cargo-install-test#697b99ee)                  
   Compiling bin1 v0.1.0 (file:///home/bram.senders/source/cargo-install-test#697b99ee)                  
    Finished release [optimized] target(s) in 0.29s
   Replacing /home/bram.senders/.cargo/bin/bin1

bram.senders@lcdesktop-08 ~> cargo install --force --git file:///home/bram.senders/source/cargo-install-test bin2
    Updating git repository `file:///home/bram.senders/source/cargo-install-test`
  Installing bin2 v0.1.0 (file:///home/bram.senders/source/cargo-install-test#697b99ee)                  
   Compiling bin2 v0.1.0 (file:///home/bram.senders/source/cargo-install-test#697b99ee)                  
    Finished release [optimized] target(s) in 0.29s
   Replacing /home/bram.senders/.cargo/bin/bin2

I'm using cargo 1.29.0 (524a578 2018-08-05).

Thanks!

@dwijnand dwijnand self-assigned this Sep 20, 2018
bors added a commit that referenced this issue Sep 20, 2018
If creating a new GitSource, updating it is required before querying it

Fixes #6059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant