Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress warning: the cargo feature edition is now stable and is no longer necessary to be listed in the manifest #6168

Closed
Boscop opened this issue Oct 12, 2018 · 3 comments · Fixed by #6277
Closed

Suppress warning: the cargo feature edition is now stable and is no longer necessary to be listed in the manifest #6168

Boscop opened this issue Oct 12, 2018 · 3 comments · Fixed by #6277

Comments

@Boscop
Copy link

Boscop commented Oct 12, 2018

I updated my nightly and I'm getting:

warning: the cargo feature edition is now stable and is no longer necessary to be listed in the manifest

It's not used in my workspace but by some dependency. Shouldn't this warning be suppressed for dependencies?
@alexcrichton
Copy link
Member

Is the dependency a path dependency or a workspace member? Or a crates.io/git dependency? Could you provide a sample repo to reproduce this?

@Boscop
Copy link
Author

Boscop commented Oct 13, 2018 •
edited
Loading

It's a path dependency, not a workspace member. But the workspace is using a newer nightly than the dependency (via rust-toolchain file), so the edition key is still needed when building the dependency crate by itself..

At least I think that's the one that this warning is about, how can I know which crate the compiler is referring to? It would be useful if it printed the name of the crate that causes this warning..

@alexcrichton
Copy link
Member

It's a bug in Cargo that the crate can't be easily found today, but it's expected behavior that the you get warnings for path dependencies.

@ehuss ehuss mentioned this issue Nov 7, 2018
Merged
bors added a commit that referenced this issue Nov 7, 2018
@bors
Auto merge of #6277 - ehuss:ws-warn-path, r=alexcrichton
1f730be 
Include path to manifest in workspace warnings.

It can be confusing because almost all of the warnings give no indication which package issued the warning.

Closes #6168
@bors bors closed this as completed in #6277 Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include path to manifest in workspace warnings. ehuss/cargo
2 participants
@alexcrichton @Boscop