-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation of environment variables is lacking #920
Comments
There are a few more from Line 3238 in 8cf5455
|
Also
|
There are also target prefixed version of Line 2180 in 8cf5455
Prefixed Line 2657 in 8cf5455
Line 2826 in 8cf5455
|
Oh, there is some documentation in README.md, but not on https://docs.rs. I think that should be moved to the crate documentation in lib.rs so it shows up on https://docs.rs. I expect to find crate usage documentation on https://docs.rs, not a README.md in the source repository. |
Maybe we could |
I think it would be simpler to just link to https://docs.rs from README.md and keep the documentation in one place (lib.rs) |
Well, if we add new env to main, then anybody who checks the doc in README would use it while it doesn't work in practice. |
Yes, I've run into that problem with another Rust library. I got confused because the README.md documented some new features that were not available in the latest release at the time. |
Yeah, that's why I think |
|
Yeah that's true, my other project simply leaves a link to latest doc on crates.io/crates/cargo-binstall to maintain consistency |
so it appears on https://docs.rs and inconsistencies aren't created between README.md and lib.rs per discussion in rust-lang#920 The old introductory text in lib.rs has been replaced with the text from README.md and the introductory paragraph revised. Otherwise no major changes to the text have been made.
so it appears on https://docs.rs and inconsistencies aren't created between README.md and lib.rs per discussion in #920 The old introductory text in lib.rs has been replaced with the text from README.md and the introductory paragraph revised. Otherwise no major changes to the text have been made.
Currently, the documentation on what environment variables this crate reads and what effects they have is lacking. For example, the try_flags_from_environment documentation merely says "Normally the cc crate will consult with the standard set of environment variables (such as CFLAGS and CXXFLAGS) to construct the compiler invocation." cc-rs uses more than
CFLAGS
andCXXFLAGS
. Here are a few topics lacking documentation:CC
/CXX
to specify the compilerCC
/CXX
can specify compiler caches and compiler flagsRUSTC_WRAPPER
can be used for C & C++ compiler caching with sccacheVCINSTALLDIR
Are there other uses of environment variables that should be documented?
The text was updated successfully, but these errors were encountered: