Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYS_calls should be bound #121

Closed
6 tasks
nagisa opened this issue Dec 29, 2015 · 8 comments
Closed
6 tasks

SYS_calls should be bound #121

nagisa opened this issue Dec 29, 2015 · 8 comments

Comments

@nagisa
Copy link
Member

nagisa commented Dec 29, 2015

Since there’s a binding to syscall function, SYS_* constants should also be bound. Perhaps in their own module, since there’s so many of them.

@alexcrichton
Copy link
Member

Sounds good to me, should be relatively easy enough to add at any time!

@kamalmarhubi
Copy link
Contributor

I am willing to take this on. I've been wanting to script getting constants anyway—at least on Linux— and this is a great excuse.

@kamalmarhubi
Copy link
Contributor

Also re Linux, I found the easiest place to get the sycall numbers is actually in from musl source, eg:

It'll be worth putting these in a joint musl / other location though. Probably unix::notbsd::linux::syscalls, which will be included by both unix::notbsd::linux with target_arch guards.

@alexcrichton
Copy link
Member

For now I'd prefer to just stick with duplication, it's not that hard to have and it presents a much more understandable organization hierarchy

@kamalmarhubi
Copy link
Contributor

Sounds good.

@posborne
Copy link
Contributor

👍 for scripting this and getting consistent, complete coverage.

@Susurrus
Copy link
Contributor

Susurrus commented Nov 8, 2017

@alexcrichton I think this is addressed as there are tons of SYS_* constants now in libc.

@alexcrichton
Copy link
Member

Indeed!

danielverkamp pushed a commit to danielverkamp/libc that referenced this issue Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants