Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summarize: Make incr-cache-loading and query-blocking contribute to self-time of query. #104

Conversation

michaelwoerister
Copy link
Member

Adjusts the logic in summarize according to #75 (comment).

The differences in absolute numbers should be small. But it is more consistent, I think.

Fixes #75.

r? @wesleywiser

@michaelwoerister
Copy link
Member Author

I might make sense to do a new release for this and switch perf.rlo over. It is the last thing missing for the MVP, I'd say.

@michaelwoerister michaelwoerister force-pushed the adjust-self-time-in-summarize branch from f91a0f3 to 6fffeaa Compare January 3, 2020 12:43
@andjo403
Copy link
Contributor

andjo403 commented Jan 7, 2020

to me this looks good.
but maybe before a new release, something that you talked about in the issue was total time and maybe you are thinking the total time in chrome tracing where you have a self time and total time for an event and I think that is missing from showing all information for events. I also think that the total time is needed for e.g. in #67

@michaelwoerister
Copy link
Member Author

@andjo403, I think what you are talking about I have seen being referred to as "inclusive" and "exclusive" times for an event. "Inclusive" would then also contain the time of child events. I think calling it "inclusive" and "exclusive" times is pretty good. Right now we only show "exclusive" times (what we call "self time"), adding a column for inclusive time to perf.rlo is a very good idea.

@michaelwoerister
Copy link
Member Author

Hm, kCacheGrind and https://github.com/KDAB/hotspot call it "self" and "inclusive" times.

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this. Looks great to me!

@wesleywiser
Copy link
Member

The Chrome profile calls this "self time" vs "total time" FWIW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants