Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return error if the file is too small instead of panicking #151

Merged
merged 1 commit into from
Feb 9, 2021
Merged

return error if the file is too small instead of panicking #151

merged 1 commit into from
Feb 9, 2021

Conversation

andjo403
Copy link
Contributor

@andjo403 andjo403 commented Feb 7, 2021

Closes #150

@andjo403 andjo403 changed the title return error if the file is to small instead of panicing return error if the file is too small instead of panicking Feb 7, 2021
wesleywiser
wesleywiser approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wesleywiser wesleywiser merged commit 3807a1f into rust-lang:master Feb 9, 2021
@andjo403 andjo403 deleted the to_small_file branch February 9, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion failure on empty files
2 participants
@andjo403 @wesleywiser