Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Inferno to generate flamegraphs #73

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

andjo403
Copy link
Contributor

@andjo403 andjo403 commented Nov 5, 2019

closes #42

@bjorn3
Copy link
Member

bjorn3 commented Nov 5, 2019

Keeping the ability to get the raw stack collapsed data is useful. You for example need them to create differential flamegraphs. It is also useful as input for other programs.

@andjo403
Copy link
Contributor Author

andjo403 commented Nov 5, 2019

shall I add a new crate toolsLib or something like that? and move the measureme/flamegraph/src/stack_collapse.rs there (later maybe also measureme/src/profiling_data.rs can be moved there) and then create the new flamegraph crate.

@michaelwoerister
Copy link
Member

This looks awesome, thanks @andjo403!

@wesleywiser
Copy link
Member

wesleywiser commented Nov 5, 2019

@andjo403 Yeah, I think I gave you bad advice on Zulip. Sorry about that!

I agree with @bjorn3 that stack_collapse is useful by itself so we shouldn't remove it.

create the new flamegraph crate

I think this is the best thing to do. Adding a new crate to the workspace will also let you reuse code from stack_collapse inside it since we shouldn't duplicate that logic.

Edit: By the way, I just want to say this looks awesome and I'm really excited to see it land! 🎉

@wesleywiser wesleywiser self-assigned this Nov 5, 2019
add crate tools_lib to reuse functionality between tools.
@andjo403
Copy link
Contributor Author

andjo403 commented Nov 5, 2019

crated the new crates tools_lib and flamegraph

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@wesleywiser wesleywiser merged commit 9d5d1e8 into rust-lang:master Nov 6, 2019
@andjo403 andjo403 deleted the inferno branch November 6, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrated FlameGraph output
4 participants