Use more compact encoding for the string table #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleywiser
reviewed
Nov 27, 2019
measureme/src/stringtable.rs
Outdated
| // Tags for the binary encoding of strings | ||
| // See module-level documentation for more information on the encoding. | ||
| const TERMINATOR: u8 = 0xFF; | ||
| const UTF8_CONTINUATION_MASK: u8 = 0b1100_0000; |
There was a problem hiding this comment.
I've never used a big endian system so this is probably a dumb question, but on big endian systems, won't these bits be backwards? (Ie, wouldn't this need to be 0b0000_0011?)
wesleywiser
approved these changes
Nov 30, 2019
|
Thanks for the review, @wesleywiser! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the encoding for the string table more compact, as described in measureme::stringtable's module-level documentation. It also moves the code for reading string tables into the
analyzemecrate.This PR concludes my planned changes to the file format for the time being. We'll need some more changes to the API in order to facilitate recording query keys but those should not require updating perf.rlo.
It's probably best to review the first commit in isolation.
r? @wesleywiser