deprecate attribute: renamed reason to note #1425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: text/0000-deprecation.md
Conflicts: text/0000-deprecation.md
|
👍 |
|
This history looks very suspicious. |
|
Yeah, it based on an old commit. I'm not sure whether to rebase or just close and resubmit with a clean branch? |
|
@llogiq rebase is being a jerk, whenever you have already pushed, so I guess the best thing to do is to open a new PR. |
|
OK then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was discussed (and accepted) on #1270 before the RFC PR was merged; unfortunately, I forgot to change the RFC text. The current implementation has the field named as "note" and is thus in violation of the RFC as merged. This PR should correct this oversight.