Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Add a "Drawbacks" section to the template. #32

Merged
merged 1 commit into from
Apr 22, 2014

Conversation

SimonSapin
Copy link
Contributor

(The name could be something else.)

Listing known disadvantages from the start will hopefully facilitate discussion.

(The name could be something else.)

Listing known disadvantages from the start will hopefully facilitate
discussion.
@alexcrichton
Copy link
Member

I would expect drawbacks to show up in either the unresolved questions or alternatives section. Perhaps we could change the placeholder wording of those sections?

@@ -10,6 +10,10 @@ One para explanation of the feature.

Why are we doing this? What use cases does it support? What is the expected outcome?

# Drawbacks

Why should we *not* do this?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/should/might/

@flaper87
Copy link

I think "Open Questions" should be used for things that we're not sure about the proposal. A "Drawbacks" sections might make sense after all to elaborate on the disadvantages of the RFC, if any.

@brson brson merged commit ee8872d into rust-lang:master Apr 22, 2014
@brson
Copy link
Contributor

brson commented Apr 22, 2014

Merged per today's discussion https://github.com/mozilla/rust/wiki/Meeting-weekly-2014-04-22

pcwalton added a commit to pcwalton/rfcs that referenced this pull request Jun 25, 2014
pcwalton added a commit that referenced this pull request Jun 25, 2014
Accepted RFC #32: Remove cross-borrowing
glaebhoerl pushed a commit to glaebhoerl/rfcs that referenced this pull request Aug 8, 2014
@Centril Centril added the A-meta Proposals about how we make proposals label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Proposals about how we make proposals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants