Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe comparison traits (PartialEq, Eq, PartialOrd, Ord) #956

Closed
wants to merge 14 commits into from
+127 −0
Closed

Unsafe comparison traits (PartialEq, Eq, PartialOrd, Ord) #956

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fca3f6a
Add unsafe-cmp RFC
theemathas Mar 9, 2015
4f75eb6
Add properties of .le() and .ge()
theemathas Mar 9, 2015
261b337
Mention cross-crate transitivity issue as per @quantheory
theemathas Mar 9, 2015
8c4ef29
Add type parameter issue
theemathas Mar 9, 2015
2cf814e
Explicitly mention that not many `unsafe`s are required
theemathas Mar 10, 2015
d71228d
Mention #[derive] in the summary
theemathas Mar 10, 2015
22b9794
Add `Relaxed` traits alternative
theemathas Mar 10, 2015
768d6cc
Mention `sort_by()`
theemathas Mar 16, 2015
7ca8fee
Add alternative as per @Gankro
theemathas Mar 18, 2015
2b55259
Add drawback about accidentally incorrect code
theemathas Mar 19, 2015
589d19b
Elaborate on alternatives
theemathas Mar 19, 2015
3818ec2
Mention `is_correct()` alternative as per @huonw
theemathas Mar 22, 2015
52ec767
Mention associated constants in alternative
theemathas Mar 22, 2015
58c893a
Mention panics, as per @bluss
theemathas Mar 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mention #[derive] in the summary
@theemathas
theemathas committed Mar 10, 2015
commit d71228df29ba96044cc81e34e514054156fa82e4
2 changes: 2 additions & 0 deletions text/0000-unsafe-cmp.md
View file
Original file line number Diff line number Diff line change
@@ -8,6 +8,8 @@
Make the four `cmp` traits (`PartialEq`, `Eq`, `PartialOrd`, and `Ord`) become
`unsafe` traits.

`#[derive]` should work as usual, minimizing the amount of `unsafe`s required.

# Motivation

Some algorithms and data structures (such as the `SliceExt::sort()` algorithm