Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code: Platform-specific Extensions #10483

Closed
Tracked by #10724
jonasbb opened this issue Oct 7, 2021 · 2 comments · Fixed by #11053
Closed
Tracked by #10724

VS Code: Platform-specific Extensions #10483

jonasbb opened this issue Oct 7, 2021 · 2 comments · Fixed by #11053
Labels
A-infra CI and workflow issues A-vscode vscode plugin issues C-feature Category: feature request good first issue S-actionable Someone could pick this issue up and work on it right now

Comments

@jonasbb
Copy link
Contributor

jonasbb commented Oct 7, 2021 •
edited
Loading

VS Code 1.61 allows using platform-specific extensions: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions
This allows creating extensions which bundle the correct binary for each platform. This would remove the need to download rust-analyzer on the first run after an update and provide a better experience for offline use or when the CI fails to upload the artifacts (#10341 (comment)).
It might also help with updates on Windows.

It might be worthwhile to consider using this feature in the future.
@flodiebold flodiebold added the A-vscode vscode plugin issues label Oct 7, 2021
@lnicola lnicola added C-feature Category: feature request S-actionable Someone could pick this issue up and work on it right now A-infra CI and workflow issues labels Oct 7, 2021
@matklad
Copy link
Member

matklad commented Oct 9, 2021

wow wow wow, we definitely should do this. It'll allow us to cur the whole download business away, which is very welcome!

@lnicola lnicola mentioned this issue Oct 11, 2021
Closed
@lnicola
Copy link
Member

lnicola commented Oct 11, 2021

It's not clear to me if we can still publish a version without a target set. Can we still support platforms we don't build for on CI, assuming the user provides a server?

@lnicola lnicola mentioned this issue Nov 8, 2021
Closed
3 tasks
@lnicola lnicola mentioned this issue Dec 8, 2021
Closed
This was referenced Dec 15, 2021
Closed
Merged
bors bot added a commit that referenced this issue Dec 15, 2021
@bors @lnicola
Merge #11029
661e3f9 
11029: internal: Refactor release workflow to reduce duplication r=lnicola a=lnicola

This reduces duplication by using `matrix` and paves the way for #10483. The `musl` builder is unchanged because it uses a container.

~~We also get rid of the MacOS 11 SDK thing, which is from when most MacOS builders were on 10.~~ Or not, the default is still 10.15.

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
@lnicola lnicola mentioned this issue Dec 18, 2021
Merged
bors bot added a commit that referenced this issue Dec 18, 2021
@bors @lnicola
Merge #11047
4c68672 
11047: internal: Prepare Code extension for bundling r=lnicola a=lnicola

CC #10483

This is slightly ugly, but we'll be able to clean it up after ripping the download parts (unless we decide to temporarily drop support for the nightlies).

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
@lnicola lnicola mentioned this issue Dec 18, 2021
Merged
@bors bors bot closed this as completed in b65d9c3 Dec 18, 2021
@lnicola lnicola mentioned this issue Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-infra CI and workflow issues A-vscode vscode plugin issues C-feature Category: feature request good first issue S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Publish platform-specific Code VSIXes lnicola/rust-analyzer
4 participants
@jonasbb @lnicola @flodiebold @matklad