-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bindgen: use clang-sys for the include path. #10
Conversation
// TODO: distinguish C and C++ paths? C++'s should be enough, I guess. | ||
for path in clang.cpp_search_paths.into_iter() { | ||
if let Ok(path) = path.into_os_string().into_string() { | ||
bind_args.push("-idirafter".to_owned()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that like -isystem
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it, I was going to use -isystem
at first, but upstream has this one. Actually I think both would work fine, this just puts it at the AFTER
search path instead of the system's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every script we wrote used -isystem
right? I think we should keep doing this.
What is upstream in that discussion btw? And why do they have to still massage the search path? Did anyone look into why libclang doesn't behave the same way as clang on that front?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I'll change it.
With "upstream" I meant crabtw. And yeah, I think there are still issues (the thing clang_sys
does is the same thing that awk script I wrote a while ago did, which is parsing the header list that clang gives).
Superseeded by #11 |
Generate opaque type for template param dependent bit field width
r? @nox