Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindgen: use clang-sys for the include path. #10

Closed
wants to merge 1 commit into from

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jul 4, 2016

r? @nox

// TODO: distinguish C and C++ paths? C++'s should be enough, I guess.
for path in clang.cpp_search_paths.into_iter() {
if let Ok(path) = path.into_os_string().into_string() {
bind_args.push("-idirafter".to_owned());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that like -isystem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it, I was going to use -isystem at first, but upstream has this one. Actually I think both would work fine, this just puts it at the AFTER search path instead of the system's.

Copy link
Contributor

@nox nox Jul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every script we wrote used -isystem right? I think we should keep doing this.

What is upstream in that discussion btw? And why do they have to still massage the search path? Did anyone look into why libclang doesn't behave the same way as clang on that front?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I'll change it.

With "upstream" I meant crabtw. And yeah, I think there are still issues (the thing clang_sys does is the same thing that awk script I wrote a while ago did, which is parsing the header list that clang gives).

@emilio
Copy link
Contributor Author

emilio commented Jul 5, 2016

Superseeded by #11

@emilio emilio closed this Jul 5, 2016
bors-servo pushed a commit that referenced this pull request Jul 5, 2016
Update syntex and use clang-sys for path-searching

This is on top of #10 because they conflicted, yet I needed clang-sys for one of the tests.

r? @nox
@jvo203 jvo203 mentioned this pull request Jan 27, 2019
Xiretza pushed a commit to Xiretza/rust-bindgen that referenced this pull request Feb 18, 2023
Generate opaque type for template param dependent bit field width
Xiretza pushed a commit to Xiretza/rust-bindgen that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants