Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix book links when viewing via Github #1494

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Fix book links when viewing via Github #1494

merged 1 commit into from
Jan 18, 2019

Conversation

Ameobea
Copy link
Contributor

@Ameobea Ameobea commented Jan 18, 2019

  • Some pages of the book's documentation markdown pages used .html in their links rather than .md. This evidently works with mdBook, but fails when viewing the pages of the book from the Github source tree.
  • The .html links were replaced with .md to fix this.

Since Google searches often end up leading to the non-GH pages version of the book, this change makes it a lot easier for users to navigate between different pages of the book when viewing it through Github directly.

 * Some pages of the book's documentation markdown pages used `.html` in their links rather than `.md`.  This evidently works with `mdBook`, but fails when viewing the pages of the book from the Github source tree.
 * The `.html` links were replaced with `.md` to fix this.
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, thanks!

@emilio emilio merged commit 42bfc23 into rust-lang:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants