Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unsafe in bitfields raw getters/setters #3124

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Use unsafe in bitfields raw getters/setters #3124

merged 3 commits into from
Feb 9, 2025

Conversation

nikkon-dev
Copy link
Contributor

@nikkon-dev nikkon-dev commented Feb 9, 2025 •
edited
Loading

Fixes #3123

@nikkon-dev
Fixes rust-lang#3123
068d4ce 
Signed-off-by: Nik Konyuchenko <spaun2002mobile@gmail.com>
@nikkon-dev nikkon-dev changed the title Fixes #3123 Use unsafe in bitfields raw getters/setters Feb 9, 2025
@nikkon-dev
Add missed unsafe in the raw_set_bit function
ee2a2ac 
Signed-off-by: Nik Konyuchenko <spaun2002mobile@gmail.com>
@nikkon-dev
Fix missed tests
115d94a 
Signed-off-by: Nik Konyuchenko <spaun2002mobile@gmail.com>
@emilio emilio added this pull request to the merge queue Feb 9, 2025
Merged via the queue into rust-lang:main with commit 115d94a Feb 9, 2025
62 checks passed
@nikkon-dev nikkon-dev deleted the nikkon-dev/fix_unsafe_bitfields branch February 9, 2025 17:46
@jinghao-jia jinghao-jia mentioned this pull request Feb 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitfield raw getters/setters generate unsafe_op_in_unsafe_fn warnings
2 participants
@nikkon-dev @emilio