Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic.md: Fix highlighting #1218

Closed
wants to merge 2 commits into from
Closed

Conversation

felixrabe
Copy link
Contributor

A "```bash" section is only meant for Bash code, not for transcripts of interactive sessions including command output.

A "```bash" section is only meant for Bash code, not for transcripts of interactive sessions including command output.
@rust-highfive
Copy link

r? @marioidival

(rust_highfive has picked a reviewer for you, use r? to override)

@marioidival
Copy link
Member

@felixrabe it's broken.

@felixrabe
Copy link
Contributor Author

My bad, forgot that ``` equals ```rust in rustdoc. Looking into the proper way to do this correctly.

@felixrabe
Copy link
Contributor Author

felixrabe commented Jul 15, 2019

https://doc.rust-lang.org/rustdoc/documentation-tests.html#attributes explains that ```text should be used here.

@marioidival
Copy link
Member

@felixrabe has conflict :(

Copy link
Member

@marioidival marioidival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict

@marioidival
Copy link
Member

@felixrabe ? =D

@tomasz-rozanski
Copy link
Contributor

tomasz-rozanski commented Sep 8, 2019

Fixed in #1222. I used shell attribute instead of text because it works better with the console output.

It's not visible in the stable edition of the book yet, but you see the change in the beta branch:
https://doc.rust-lang.org/beta/rust-by-example/std/panic.html

@marioidival
Copy link
Member

oh, thanks @Rosto75 💃

@marioidival marioidival closed this Sep 9, 2019
@tomasz-rozanski
Copy link
Contributor

oh, thanks @Rosto75 💃

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants