Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Known problems" section to needless_borrow documentation #11148

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented Jul 13, 2023

While this PR doesn't fix the issue in #11142, it at least communicates that this is a known limitation.

r? @Jarcho

changelog: Add "Known problems" section to needless_borrow documentation

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 13, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Jul 13, 2023

Thank you. @bors r+

Just as an aside, GitHub's overzealous automatic issue linking for PR's triggers whenever you type fix #number. Please try to be careful when wording PR descriptions to workaround GitHub's issues. fixes, fixed, close, closes, closed, resolve, resolves, and resolved all trigger the same thing.

@bors
Copy link
Contributor

bors commented Jul 13, 2023

📌 Commit 050b714 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 13, 2023

⌛ Testing commit 050b714 with merge b10a0aa...

@smoelius
Copy link
Contributor Author

Just as an aside, GitHub's overzealous automatic issue linking for PR's triggers whenever you type fix #number. Please try to be careful when wording PR descriptions to workaround GitHub's issues. fixes, fixed, close, closes, closed, resolve, resolves, and resolved all trigger the same thing.

😬 My sincerest apologies. Thank you for fixing that.

@bors
Copy link
Contributor

bors commented Jul 13, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing b10a0aa to master...

@bors bors merged commit b10a0aa into rust-lang:master Jul 13, 2023
@smoelius smoelius deleted the nb-known-problems branch July 13, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants