Start removing snippet_opt in favor of get_source_text
#13244
Conversation
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
xFrednet
added
the
performance-project
Remove more `snippet_opt` calls First commit is the same as #13244 changelog: none
clippy_lints/src/from_over_into.rs
Outdated
| let from = from.as_str(); | ||
| let into = into.as_str(); |
There was a problem hiding this comment.
These look like they'd be unneeded
| @@ -83,7 +84,7 @@ impl<'tcx> LateLintPass<'tcx> for BorrowDerefRef { | |||
| diag.span_suggestion( | |||
| e.span, | |||
| "if you would like to reborrow, try removing `&*`", | |||
| snippet_opt(cx, deref_target.span).unwrap(), | |||
| deref_text.as_str(), | |||
There was a problem hiding this comment.
Can we impl the Into<DiagnosticThingy> to pass this as is? I think this will come up a bunch
There was a problem hiding this comment.
span_suggestion only requires ToString. deref_text is used right afterwards so it doesn't help here.
There was a problem hiding this comment.
Ahh yeah, was thinking of the wrong arg 🤦♂️
Jarcho
force-pushed
the
get_src_display
branch
from
9f020d8 to
ac25730
Compare
Jarcho
force-pushed
the
get_src_display
branch
from
ac25730 to
8a4c34a
Compare
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Continuing the job of removing unnecessary allocations.
changelog: none