Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expect_fun_call lint suggestions #3690

Merged
merged 2 commits into from Jan 26, 2019
Merged

Fix expect_fun_call lint suggestions #3690

merged 2 commits into from Jan 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 24, 2019

This commit corrects some bad suggestions produced by the
expect_fun_call lint and enables rust-fix checking on the tests.

Addresses #3630

This commit corrects some bad suggestions produced by the
`expect_fun_call` lint and enables `rust-fix` checking on the tests.

Addresses #3630
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some refactoring nits 👍

@phansch
Copy link
Member

phansch commented Jan 26, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jan 26, 2019

📌 Commit 18cacba has been approved by phansch

@bors
Copy link
Contributor

bors commented Jan 26, 2019

⌛ Testing commit 18cacba with merge 33a0fe7...

bors added a commit that referenced this pull request Jan 26, 2019
Fix `expect_fun_call` lint suggestions

This commit corrects some bad suggestions produced by the
`expect_fun_call` lint and enables `rust-fix` checking on the tests.

Addresses #3630
@bors
Copy link
Contributor

bors commented Jan 26, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 33a0fe7 to master...

@bors bors merged commit 18cacba into rust-lang:master Jan 26, 2019
@ghost ghost mentioned this pull request Mar 5, 2019
@ghost ghost deleted the fix-3630-expect-fun-call branch May 11, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants