Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of eval_order_dependence #7634

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

chansuke
Copy link
Contributor

@chansuke chansuke commented Sep 4, 2021

Fixes #7624.

changelog: fix documentation of eval_order_dependence

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 4, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 5, 2021

📌 Commit b2f01ef has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Sep 5, 2021

⌛ Testing commit b2f01ef with merge b5b5185...

bors added a commit that referenced this pull request Sep 5, 2021
…shearth

Fix documentation of eval_order_dependence

Fixes #7624.
@bors
Copy link
Contributor

bors commented Sep 5, 2021

💔 Test failed - checks-action_test

@matthiaskrgr
Copy link
Member

@chansuke you'll need a changelog entry in your pr text, if you just add something like

changelog: fix documentation of eval_order_dependence

under "Fixes #7624." (it needs to be a separate line) on github, that should do it.

@Manishearth
Copy link
Member

@bors r+

Added it myself

@bors
Copy link
Contributor

bors commented Sep 6, 2021

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Sep 6, 2021

📌 Commit b2f01ef has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Sep 6, 2021

⌛ Testing commit b2f01ef with merge 17294b8...

@bors
Copy link
Contributor

bors commented Sep 6, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 17294b8 to master...

@bors bors merged commit 17294b8 into rust-lang:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated eval_order_dependence documentation
5 participants