Skip to content

Commit

Permalink
Add support for diff3 format
Browse files Browse the repository at this point in the history
  • Loading branch information
estebank committed Dec 29, 2022
1 parent 698ebe3 commit 62c8e31
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
7 changes: 7 additions & 0 deletions compiler/rustc_parse/src/parser/diagnostics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2579,12 +2579,16 @@ impl<'a> Parser<'a> {
};
let mut spans = Vec::with_capacity(3);
spans.push(start);
let mut middlediff3 = None;
let mut middle = None;
let mut end = None;
loop {
if self.token.kind == TokenKind::Eof {
break;
}
if let Some(span) = self.diff_marker(&TokenKind::OrOr, &TokenKind::BinOp(token::Or)) {
middlediff3 = Some(span);
}
if let Some(span) = self.diff_marker(&TokenKind::EqEq, &TokenKind::Eq) {
middle = Some(span);
}
Expand All @@ -2597,6 +2601,9 @@ impl<'a> Parser<'a> {
}
let mut err = self.struct_span_err(spans, "encountered diff marker");
err.span_label(start, "after this is the code before the merge");
if let Some(middle) = middlediff3 {
err.span_label(middle, "");
}
if let Some(middle) = middle {
err.span_label(middle, "");
}
Expand Down
4 changes: 3 additions & 1 deletion src/test/ui/parser/diff-markers/enum-2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ enum E {
Foo {
<<<<<<< HEAD //~ ERROR encountered diff marker
x: u8,
|||||||
z: (),
=======
x: i8,
y: i8,
>>>>>>> branch
}
}
5 changes: 4 additions & 1 deletion src/test/ui/parser/diff-markers/enum-2.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@ error: encountered diff marker
LL | <<<<<<< HEAD
| ^^^^^^^ after this is the code before the merge
LL | x: u8,
LL | |||||||
| -------
LL | z: (),
LL | =======
| -------
LL | x: i8,
LL | y: i8,
LL | >>>>>>> branch
| ^^^^^^^ above this are the incoming code changes
|
Expand Down

0 comments on commit 62c8e31

Please sign in to comment.