-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustc bootstrap build is unable to find crates in poky after 1.76 version update #122075
Comments
maybe cc: @onur-ozkan since they helped last time? @rustbot label -I-prioritize |
Thanks for the ping. I will check it in couple days. |
I can't see which build step is failing in the error log. Can you share it as well ? @Yashinde145 |
The build fails when At the end of the log file, it has the command which fails (line no 11982)
|
Can you share entire logs and the build configuration (config.toml) using gist or something else? |
Here is the link to gist: https://gist.github.com/Yashinde145/fa38c1a1fdd944483e9f531f5a65553e |
Could you please try applying this patch (in diff --git a/src/bootstrap/src/core/build_steps/test.rs b/src/bootstrap/src/core/build_steps/test.rs
index 4a4497e57db..da8c88dcd41 100644
--- a/src/bootstrap/src/core/build_steps/test.rs
+++ b/src/bootstrap/src/core/build_steps/test.rs
@@ -2571,7 +2571,7 @@ fn run(self, builder: &Builder<'_>) {
// version of libstd, then what we're actually testing is the libstd
// produced in stage1. Reflect that here by updating the compiler that
// we're working with automatically.
- let compiler = builder.compiler_for(compiler.stage, compiler.host, target);
+ let compiler = builder.compiler_for(compiler.stage, target, target);
let mut cargo = builder::Cargo::new(
builder, This should fix the problem of using an incorrect sysroot which seems to be the reason of your build failure. |
If that don't work, you could try this one too: diff --git a/src/bootstrap/src/core/build_steps/test.rs b/src/bootstrap/src/core/build_steps/test.rs
index 4a4497e57db..282c009eb7c 100644
--- a/src/bootstrap/src/core/build_steps/test.rs
+++ b/src/bootstrap/src/core/build_steps/test.rs
@@ -2572,6 +2572,7 @@ fn run(self, builder: &Builder<'_>) {
// produced in stage1. Reflect that here by updating the compiler that
// we're working with automatically.
let compiler = builder.compiler_for(compiler.stage, compiler.host, target);
+ builder.ensure(compile::Rustc::new(compiler, target));
let mut cargo = builder::Cargo::new(
builder, |
I will check with the patches and get back. |
#122075 (comment) first patch doesn't work. |
I tried running
That's strange. What exactly happens then? |
Surprisingly, I didn't observe this problem in rust version 1.75.
I have added another gist file for the build log after applying #122205 patch. I see that the following lines are newly seen after applying above patch:
Does this change alter x.py? Do I need to update my Also, can you share with me the steps to debug and fix these kind of rustc bootstrap build issues? I would like to first try and find a fix by myself before asking here. |
No.
I simply did
In the logs I can see that a portion of the tests were executed successfully. Could you please share the full version of the executed command (x) ? |
Command:
|
I need the full version (without placeholders like |
|
You are trying to test docs ( @rustbot label -I-regression-untriaged |
This is neither a bug nor a regression. You have always been ignoring tests with the |
In rust 1.75 version I was able to run tests with
I checked without using Full log for more details: log_1_76_without_doc_flag.txt
|
Those are ui tests not doc tests.
I can't see errors in this log file. |
Oh, I see. Failing tests in the log file are unit tests and previously you were not running them with |
Sure, I have created #122285 for it. |
Thanks, I am closing this one as it's no longer relevant. |
I am building rust 1.76 and then testing it using the same command(
python3 src/bootstrap/bootstrap.py test test_suites_names --target x86_64-poky-linux-gnu
in poky environment) as mentioned in #115642 (comment).While bootstrapping the rustc for poky target(x86_64-poky-linux-gnu), the build is unable to fetch the standard crates and macros and thus the build fails. Since, the build is not completed successfully, testing also doesn't take place. This didn't happened till rust 1.75.
The following is a small portion of error log:
Complete log file is attached for more details. (Build log starts from line 65)
Are there any significant changes with respect to building rustc and crates on custom targets from 1.75 to 1.76? I tried to check the release notes but couldn't find.
Am I missing something or doing anything wrong?
The text was updated successfully, but these errors were encountered: