Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x test doesn't work for absolute paths #126765

Closed
oriongonza opened this issue Jun 20, 2024 · 0 comments · Fixed by #126782
Closed

x test doesn't work for absolute paths #126765

oriongonza opened this issue Jun 20, 2024 · 0 comments · Fixed by #126782
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@oriongonza
Copy link
Contributor 

❯ x test    /home/ardi/repos/rust/tests/ui/impl-trait/precise-capturing/unexpected-token.rs
Building bootstrap
   Compiling build_helper v0.1.0 (/home/ardi/repos/rust/src/tools/build_helper)
   Compiling bootstrap v0.0.0 (/home/ardi/repos/rust/src/bootstrap)
    Finished `dev` profile [unoptimized] target(s) in 7.20s
Updating submodule src/tools/cargo
fatal: ref HEAD is not a symbolic ref
Submodule path 'src/tools/cargo': checked out '3ed207e416fb2f678a40cc79c02dcf4f936a21ce'
ERROR: no `test` rules matched ["/home/ardi/repos/rust/tests/ui/impl-trait/precise-capturing/unexpected-token.rs"]
HELP: run `x.py test --help --verbose` to show a list of available paths
NOTE: if you are adding a new Step to bootstrap itself, make sure you register it with `describe!`
Build completed unsuccessfully in 0:00:08
@oriongonza oriongonza added the C-bug Category: This is a bug. label Jun 20, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 20, 2024
@mtilda mtilda mentioned this issue Jun 21, 2024
Merged
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jun 23, 2024
@bors bors closed this as completed in 92af670 Jun 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jun 23, 2024
@rust-timer
Unrolled build for rust-lang#126782
d79b446 
Rollup merge of rust-lang#126782 - mtilda:mtilda/patch/x-test-with-absolute-paths, r=onur-ozkan

Support absolute source paths in bootstrap

Fixes rust-lang#126765

`x test [PATHS]` should work when each path

1. Is the name of a build step, such as `tidy` in `x test tidy` or
2. Points to an existing file that is a descendant of the builder's source directory (root of this repository).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support absolute source paths in bootstrap mtilda/rust
3 participants
@jieyouxu @oriongonza @rustbot