Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address time library FIXMEs #2350

Closed
catamorphism opened this issue May 4, 2012 · 13 comments
Closed

Address time library FIXMEs #2350

catamorphism opened this issue May 4, 2012 · 13 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

Just making one issue since there are many FIXMEs:

  • "range check" (appears several places)
  • implement missing types in strftime
  • standardize on the timezone abbreviation
  • flesh out tests in test_strptime
@ScriptDevil ScriptDevil mentioned this issue Jan 13, 2013
Merged
@catamorphism
Copy link
Contributor Author

5de1ca9 addresses range checking.

@emberian
Copy link
Member

emberian commented Aug 5, 2013

Visiting for triage; nothing to add

sfackler added a commit to sfackler/rust that referenced this issue Sep 6, 2013
@sfackler
Add fractional second support to str{p,f}time
3c30ecb 
The ISO 8601 standard does not mandate any specific precision for
fractional seconds, so this accepts input of any length, ignoring the
part after the nanoseconds place. It may be more correct to round with
the tenths of nanoseconds digit, but then we'd have to deal with
carrying the round through the entire Tm struct (e.g. for a time like
Dec 31 11:59.999999999999).

%f is the format specifier that Python's datetime library uses for
0-padded microseconds so it seemed appropriate here.

cc rust-lang#2350
@sfackler sfackler mentioned this issue Sep 6, 2013
Closed
bors added a commit that referenced this issue Sep 7, 2013
@bors
auto merge of #9016 : sfackler/rust/nanoseconds, r=alexcrichton
3e6de6b 
The ISO 8601 standard does not mandate any specific precision for
fractional seconds, so this accepts input of any length, ignoring the
part after the nanoseconds place. It may be more correct to round with
the tenths of nanoseconds digit, but then we'd have to deal with
carrying the round through the entire Tm struct (e.g. for a time like
Dec 31 11:59.999999999999).

%f is the format specifier that Python's datetime library uses for
0-padded microseconds so it seemed appropriate here.

cc #2350
@catamorphism
Copy link
Contributor Author

Just a bug, de-milestoning

@luisbg
Copy link
Contributor

luisbg commented Sep 30, 2013

Going to spend tomorrow adding more types in do_strftime().
Stating it to avoid work clashing.

@luisbg
Copy link
Contributor

luisbg commented Oct 1, 2013

OK. Got it :)
Just cleaning the code now before creating a Pull Request

@luisbg
Copy link
Contributor

luisbg commented Oct 2, 2013

r? @catamorphism
or
r? @jdm

@emberian
Copy link
Member

emberian commented Oct 2, 2013

@luisbg where is the pull request?

@huonw
Copy link
Member

huonw commented Oct 2, 2013

#9670

luisbg added a commit to luisbg/rust that referenced this issue Oct 2, 2013
@luisbg
extra: %G, %g and %V support in time::strftime
1005b79 
Fixes rust-lang#2350
@luisbg
Copy link
Contributor

luisbg commented Oct 2, 2013

Changed the function name to days_in_year() as @kud1ing suggested, and fixed the errors.
Can we test this?

r? @catamorphism

@bors bors closed this as completed in c463772 Oct 2, 2013
@bstrie bstrie reopened this Oct 2, 2013
@bstrie
Copy link
Contributor

bstrie commented Oct 2, 2013

This was not intended to be closed by c463772.

@luisbg
Copy link
Contributor

luisbg commented Oct 2, 2013

Sorry about that.

luisbg added a commit to luisbg/rust that referenced this issue Oct 2, 2013
@luisbg
extra: %W and %+ support in time::strftime
8f6e43e 
Plus testing added for %X and %x which were supported but not tested.

Working towards rust-lang#2350
@luisbg luisbg mentioned this issue Oct 2, 2013
Merged
bors added a commit that referenced this issue Oct 3, 2013
@bors
auto merge of #9689 : luisbg/rust/strftime, r=alexcrichton
2076073 
Plus testing added for %X and %x which were supported but not tested.

Working towards #2350
luisbg added a commit to luisbg/rust that referenced this issue Oct 3, 2013
@luisbg
extra: %W support in time:strptime
5ffd415 
Working towards rust-lang#2350
luisbg added a commit to luisbg/rust that referenced this issue Oct 4, 2013
@luisbg
extra: %W support in time:strptime
33f5153 
Working towards rust-lang#2350
@flaper87
Copy link
Contributor

triage bump

@omasanori omasanori mentioned this issue Aug 30, 2014
Closed
@brson
Copy link
Contributor

brson commented Jan 13, 2015

This crate is no longer a concern in-tree.

@brson brson closed this as completed Jan 13, 2015
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2350 - RalfJung:remove-deprecated, r=oli-obk
8757d86 
remove deprecated options

These have been deprecated a month ago and nobody said they need them. Is that enough time? We can also let this PR sit a little.

Cc rust-lang/miri#2187 rust-lang/miri#2188
(keeping them open to track removing their supporting infrastructure in the core interpreter)
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval
Bump our packages version to 0.25.0 (rust-lang#2350)
b53b3ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@flaper87 @brson @luisbg @catamorphism @emberian @bstrie @huonw