Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the new individual const fn feature gates #44644

Closed
durka opened this issue Sep 17, 2017 · 11 comments
Closed

Document the new individual const fn feature gates #44644

durka opened this issue Sep 17, 2017 · 11 comments
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority

Comments

@durka
Copy link
Contributor

durka commented Sep 17, 2017

Introduced in #43017. Do they need individual tracking issues as well?

@durka
Copy link
Contributor Author

durka commented Sep 17, 2017

Also, this information should be exposed in rustdoc somehow. cc @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

I'm not sure how though...

@est31
Copy link
Member

est31 commented Sep 17, 2017

@durka features can share tracking issues. The other way doesn't work though, a feature can only have at most one tracking issue.

@durka
Copy link
Contributor Author

durka commented Sep 17, 2017

@est31 these aren't normal features so we can do whatever we want :) My plan is to create one tracking issue for all of them, and if one function turns out to need a lot of discussion it can be split off.

@TimNN TimNN added A-const-fn C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Sep 17, 2017
@est31
Copy link
Member

est31 commented Sep 17, 2017

@durka all I'm saying that there is precedent for features sharing tracking issues, but there is no precedent for features having multiple tracking issues. Why would that make sense in the first place? It would just confuse people to have multiple tracking issues for one feature gate. Anyway, I definitely agree with having one tracking issue for all the const fn feature gates.

@durka
Copy link
Contributor Author

durka commented Sep 17, 2017 via email

@steveklabnik
Copy link
Member

I'm a bit confused; introducing new features should require new pages in the unstable book, it doesn't seem like they exist though?

tagging as medium to sort this out

@steveklabnik steveklabnik added the P-medium Medium priority label Oct 31, 2017
@est31
Copy link
Member

est31 commented Oct 31, 2017

@steveklabnik it autogenerates missing files during doc generation, in a step before the actual md is converted to html so the stub shows up in the rendered output. This makes contributing to the compiler easier because its less red tape to add a new feature. Users will still see the stub, so nothing has changed for them. If autogeneration doesn't work, please ping me!

@steveklabnik
Copy link
Member

If autogeneration doesn't work, please ping me!

Yes, I think that's the problem, as we're not seeing pages for those feature gates.

@durka
Copy link
Contributor Author

durka commented Oct 31, 2017 via email

@steveklabnik
Copy link
Member

#45671 should have made this possible, and we don't require docs for any particular flags, so closing!

@RalfJung RalfJung added the A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority
Projects
None yet
Development

No branches or pull requests

6 participants