Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefIndex can use newtype_index! #60666

Closed
petrochenkov opened this issue May 9, 2019 · 7 comments
Closed

DefIndex can use newtype_index! #60666

petrochenkov opened this issue May 9, 2019 · 7 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@petrochenkov
Copy link
Contributor

#60647 (comment)

Note, this could probably be further simplified by using newtype_index! for DefIndex and switching things to IndexVec<DefIndex, _> where appropriate. But let's land this first :)
@petrochenkov petrochenkov added C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels May 9, 2019
@petrochenkov
Copy link
Contributor Author

cc @fabric-and-ink

@fabric-and-ink
Copy link
Contributor

I will look into it!

@petrochenkov
Copy link
Contributor Author

Two more possible cleanups that are possible after removal of DefIndexAddressSpace:
#60647 (comment)
#60647 (comment)

@fabric-and-ink fabric-and-ink mentioned this issue May 18, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue May 19, 2019
@Centril
Rollup merge of rust-lang#60934 - fabric-and-ink:defindex_with_newtyp…
7cbca59 
…e_macro, r=petrochenkov

Declare DefIndex with the newtype_index macro

See rust-lang#60666
@fabric-and-ink
Copy link
Contributor

I think, this can be closed now.

@oli-obk
Copy link
Contributor

oli-obk commented May 27, 2019

@fabric-and-ink the two linked comments are still unresolved I think?

@fabric-and-ink
Copy link
Contributor

You are right. I had the original topic in mind.

One of the linked comments is resolved. I don't know how to resolve the second one.

@petrochenkov
Copy link
Contributor Author

The second is fixed in #59953, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oli-obk @petrochenkov @fabric-and-ink