Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Which is accessor method of MetadataExt? #62711

Closed
tesuji opened this issue Jul 16, 2019 · 3 comments · Fixed by #63327
Closed

Which is accessor method of MetadataExt? #62711

tesuji opened this issue Jul 16, 2019 · 3 comments · Fixed by #63327
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. O-linux Operating system: Linux

Comments

@tesuji
Copy link
Contributor

tesuji commented Jul 16, 2019

rust/src/libstd/os/linux/fs.rs

Lines 36 to 41 in 4b65a86

#[stable(feature = "metadata_ext", since = "1.1.0")]
#[rustc_deprecated(since = "1.8.0",
reason = "deprecated in favor of the accessor \
methods of this trait")]
#[allow(deprecated)]
fn as_raw_stat(&self) -> &raw::stat;

@hellow554
Copy link
Contributor

as_raw_stat returned the stat struct containing all the information.
Now you should access them via the methods provided by the trait, e.g. st_dev, st_ino, st_mode etc.

@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. O-linux Operating system: Linux A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 16, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Jul 16, 2019 •
edited
Loading

Thanks for explanation. But I think the deprecated message is misleading.

@Mark-Simulacrum
Copy link
Member

PRs to change the wording would likely be accepted, but nothing better comes to mind right now. It seems pretty straightforward to me what the deprecation means.

@Mark-Simulacrum Mark-Simulacrum removed the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 5, 2019
@tesuji tesuji mentioned this issue Aug 6, 2019
Merged
pietroalbini added a commit to pietroalbini/rust that referenced this issue Aug 7, 2019
@pietroalbini
Rollup merge of rust-lang#63327 - lzutao:fix-as_raw_stat-dep-msg, r=M…
4eb7ec6 
…ark-Simulacrum

doc: Reword deprecation message of MetadataExt::as_raw_stat

Closes rust-lang#62711
r? @Mark-Simulacrum
Centril added a commit to Centril/rust that referenced this issue Aug 8, 2019
@Centril
Rollup merge of rust-lang#63327 - lzutao:fix-as_raw_stat-dep-msg, r=M…
46e7cb4 
…ark-Simulacrum

doc: Reword deprecation message of MetadataExt::as_raw_stat

Closes rust-lang#62711
r? @Mark-Simulacrum
Centril added a commit to Centril/rust that referenced this issue Aug 8, 2019
@Centril
Rollup merge of rust-lang#63327 - lzutao:fix-as_raw_stat-dep-msg, r=M…
ab9a95b 
…ark-Simulacrum

doc: Reword deprecation message of MetadataExt::as_raw_stat

Closes rust-lang#62711
r? @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. O-linux Operating system: Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: Reword deprecation message of MetadataExt::as_raw_stat tesuji/rustc
4 participants
@hellow554 @jonas-schievink @Mark-Simulacrum @tesuji