Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax in E0191 explanation. #115054

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix syntax in E0191 explanation. #115054

merged 1 commit into from
Aug 21, 2023

Conversation

waywardmonkeys
Copy link
Contributor

This trait needs dyn in modern Rust.

Fixes #115042.

@waywardmonkeys
Fix syntax in E0191 explanation.
fd2982c 
This trait needs `dyn` in modern Rust.

Fixes rust-lang#115042.
@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 21, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 21, 2023

📌 Commit fd2982c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 21, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 21, 2023
@matthiaskrgr
Rollup merge of rust-lang#115054 - waywardmonkeys:fix-syntax-in-e0191…
8a10d2a 
…, r=compiler-errors

Fix syntax in E0191 explanation.

This trait needs `dyn` in modern Rust.

Fixes rust-lang#115042.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2023
@bors
Auto merge of rust-lang#115074 - matthiaskrgr:rollup-au2i7k0, r=matth…
ef85656 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#115044 (stable_mir: docs clarification)
 - rust-lang#115054 (Fix syntax in E0191 explanation.)
 - rust-lang#115067 (docs: add alias log1p to ln_1p)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 66726fd into rust-lang:master Aug 21, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 21, 2023
@waywardmonkeys waywardmonkeys deleted the fix-syntax-in-e0191 branch August 21, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

Update the examples for E0191
5 participants
@waywardmonkeys @rustbot @compiler-errors @bors @cjgillot