Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Clippy beta backport #117757

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[beta] Clippy beta backport #117757

merged 1 commit into from
Nov 10, 2023

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Nov 9, 2023

Follow-up to the stable backport done in

r? @Mark-Simulacrum

@bors @flip1995
Auto merge of rust-lang#11596 - blyxyas:fix-fp-needless_pass_by_ref_m…
a46e1c9 
…ut, r=Jarcho

Move `needless_pass_by_ref_mut`: `suspicious` -> `nursery`

[Related to [this Zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/needless_pass_by_ref_mut.20isn't.20ready.20for.20stable)]

`needless_pass_by_ref_mut` has been released with some important bugs (notably having a lot of reported false positives and an ICE). So it may not be really ready for being in stable until these problems are solved. This PR changes the lint's category from `suspicious` to `nursery`, just that.
changelog: none
@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 9, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@cuviper
Copy link
Member

cuviper commented Nov 10, 2023

I confirmed that this is in nursery on stable and master, so yes we should update beta too.

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Nov 10, 2023

📌 Commit a46e1c9 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2023
@bors
Copy link
Contributor

bors commented Nov 10, 2023

⌛ Testing commit a46e1c9 with merge 22d4a4f...

@bors
Copy link
Contributor

bors commented Nov 10, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 22d4a4f to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 10, 2023
@bors bors merged commit 22d4a4f into rust-lang:beta Nov 10, 2023
@rustbot rustbot added this to the 1.74.0 milestone Nov 10, 2023
@flip1995 flip1995 deleted the clippy-beta-backport branch November 10, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
5 participants
@flip1995 @rustbot @cuviper @bors @Mark-Simulacrum