const traits: remove some known-bug that do not seem to make sense #135523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#135497 (fix typo in typenames of pin documentation) - rust-lang#135522 (add incremental test for issue 135514) - rust-lang#135523 (const traits: remove some known-bug that do not seem to make sense) - rust-lang#135535 (Add GUI test for rust-lang#135499) - rust-lang#135541 (Methods of const traits are const) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2025
Rollup merge of rust-lang#135523 - RalfJung:wrong-known-bug, r=compiler-errors const traits: remove some known-bug that do not seem to make sense These tests were made to point to rust-lang#103507 in rust-lang#114134; I think that was a mistake: that issue is about a rather specific problem, and most tests marked as known-bug in that PR are pointing at rust-lang#110395 which makes more sense. Of the 4 tests that still point to rust-lang#103507: - One is [the original test](https://github.com/rust-lang/rust/blob/20882608529a969bd878ad787cf0038716c021df/tests/ui/impl-trait/normalize-tait-in-const.rs). It still fails to compile, though currently for unrelated reasons (`~const Fn` is not valid as that is not a const trait). I made it point at rust-lang#110395 like all the other tests that were disabled when the previous const trait impl was removed. - One is being fixed in rust-lang#135423 - The other two are fixed in this PR The errors we are getting here are not great but they do look correct? FWIW there are still a whole lot of tests mentioning rust-lang#110395 despite that issue being closed... I hope someone is tracking that.^^ r? `@compiler-errors`
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#135497 (fix typo in typenames of pin documentation) - rust-lang#135522 (add incremental test for issue 135514) - rust-lang#135523 (const traits: remove some known-bug that do not seem to make sense) - rust-lang#135535 (Add GUI test for rust-lang#135499) - rust-lang#135541 (Methods of const traits are const) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were made to point to #103507 in #114134; I think that was a mistake: that issue is about a rather specific problem, and most tests marked as known-bug in that PR are pointing at #110395 which makes more sense.
Of the 4 tests that still point to #103507:
~const Fnis not valid as that is not a const trait). I made it point at Tracking Issue for removingimpl constand~constin the standard library #110395 like all the other tests that were disabled when the previous const trait impl was removed.The errors we are getting here are not great but they do look correct?
FWIW there are still a whole lot of tests mentioning #110395 despite that issue being closed... I hope someone is tracking that.^^
r? @compiler-errors