Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi: process: Add support for command environment variables #136418

Merged
merged 1 commit into from
Feb 6, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 62 additions & 3 deletions library/std/src/sys/pal/uefi/process.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use r_efi::protocols::simple_text_output;

use super::helpers;
use crate::collections::BTreeMap;
pub use crate::ffi::OsString as EnvKey;
use crate::ffi::{OsStr, OsString};
use crate::num::{NonZero, NonZeroI32};
Expand All @@ -21,6 +22,7 @@ pub struct Command {
args: Vec<OsString>,
stdout: Option<Stdio>,
stderr: Option<Stdio>,
env: CommandEnv,
}

// passed back to std::process with the pipes connected to the child, if any
Expand All @@ -40,15 +42,21 @@ pub enum Stdio {

impl Command {
pub fn new(program: &OsStr) -> Command {
Command { prog: program.to_os_string(), args: Vec::new(), stdout: None, stderr: None }
Command {
prog: program.to_os_string(),
args: Vec::new(),
stdout: None,
stderr: None,
env: Default::default(),
}
}

pub fn arg(&mut self, arg: &OsStr) {
self.args.push(arg.to_os_string());
}

pub fn env_mut(&mut self) -> &mut CommandEnv {
panic!("unsupported")
&mut self.env
}

pub fn cwd(&mut self, _dir: &OsStr) {
Expand Down Expand Up @@ -76,7 +84,7 @@ impl Command {
}

pub fn get_envs(&self) -> CommandEnvs<'_> {
panic!("unsupported")
self.env.iter()
}

pub fn get_current_dir(&self) -> Option<&Path> {
Expand Down Expand Up @@ -140,8 +148,30 @@ impl Command {
cmd.stderr_inherit()
};

let env = env_changes(&self.env);

// Set any new vars
if let Some(e) = &env {
for (k, (_, v)) in e {
match v {
Some(v) => crate::env::set_var(k, v),
None => crate::env::remove_var(k),
}
}
}

let stat = cmd.start_image()?;

// Rollback any env changes
if let Some(e) = env {
for (k, (v, _)) in e {
match v {
Some(v) => crate::env::set_var(k, v),
None => crate::env::remove_var(k),
}
}
}

let stdout = cmd.stdout()?;
let stderr = cmd.stderr()?;

Expand Down Expand Up @@ -725,3 +755,32 @@ mod uefi_command_internal {
res.into_boxed_slice()
}
}

/// Create a map of environment variable changes. Allows efficient setting and rolling back of
/// enviroment variable changes.
///
/// Entry: (Old Value, New Value)
fn env_changes(env: &CommandEnv) -> Option<BTreeMap<EnvKey, (Option<OsString>, Option<OsString>)>> {
if env.is_unchanged() {
return None;
}

let mut result = BTreeMap::<EnvKey, (Option<OsString>, Option<OsString>)>::new();

// Check if we want to clear all prior variables
if env.does_clear() {
for (k, v) in crate::env::vars_os() {
result.insert(k.into(), (Some(v), None));
}
}

for (k, v) in env.iter() {
let v: Option<OsString> = v.map(Into::into);
result
.entry(k.into())
.and_modify(|cur| *cur = (cur.0.clone(), v.clone()))
.or_insert((crate::env::var_os(k), v));
}

Some(result)
}
Loading