Remove `NtItem` and `NtStmt` #138083

nnethercote · 2025-03-06T02:06:19Z

Another piece of #124141.

r? @petrochenkov

rustbot · 2025-03-06T02:06:25Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_sanitizers

cc @rust-lang/project-exploit-mitigations, @rcvalle

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

compiler/rustc_ast/src/lib.rs

compiler/rustc_expand/src/proc_macro_server.rs

compiler/rustc_parse/src/parser/stmt.rs

petrochenkov · 2025-03-06T14:17:52Z

The rustdoc overflows are probably from the extra passes that rustdoc runs to determine the full set of auto trait implementations to document.
Although I'm still not sure why is the recursion level increased by this change.
@rustbot author

nnethercote · 2025-03-07T01:50:55Z

I added the cfg_attr conditions to the recursion_limit increases. I left everything else unchanged because I think it's necessary.

This involves replacing `nt_pretty_printing_compatibility_hack` with `stream_pretty_printing_compatibility_hack`. The handling of statements in `transcribe` is slightly different to other nonterminal kinds, due to the lack of `from_ast` implementation for empty statements. Notable test changes: - `tests/ui/proc-macro/expand-to-derive.rs`: the diff looks large but the only difference is the insertion of a single invisible-delimited group around a metavar.

This is temporarily needed for `x doc compiler` to work. They can be removed once the `Nonterminal` is removed (rust-lang#124141).

This time when converting them to proc-macro `Group` form.

nnethercote · 2025-03-07T06:35:45Z

@bors try @rust-timer queue

Remove `NtItem` and `NtStmt` Another piece of rust-lang#124141. r? `@petrochenkov`

bors · 2025-03-07T06:36:57Z

⌛ Trying commit 3378ee1 with merge 17de919...

bors · 2025-03-07T08:35:27Z

☀️ Try build successful - checks-actions
Build commit: 17de919 (17de9196568986e11f218c0c5a9a7c6c608f1cd3)

rust-timer · 2025-03-07T09:50:58Z

Finished benchmarking commit (17de919): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	2.2%	[0.2%, 3.1%]	14
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.2%]	6
All ❌✅ (primary)	2.2%	[0.2%, 3.1%]	14

Max RSS (memory usage)

Results (primary -0.7%, secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[3.3%, 3.3%]	1
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-2.7%	[-3.0%, -2.3%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-3.0%, 3.3%]	3

Cycles

Results (primary 2.7%, secondary 4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.1%, 3.8%]	9
Regressions ❌ (secondary)	4.0%	[4.0%, 4.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[2.1%, 3.8%]	9

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 765.289s -> 764.767s (-0.07%)
Artifact size: 362.07 MiB -> 362.08 MiB (0.00%)

petrochenkov · 2025-03-07T10:57:28Z

r=me unless you want to check why compiling libc is slow.

It it's due to stream_pretty_printing_compatibility_hack, then maybe a couple of tokens of look ahead will help to filter away everything that is not relevant to rental hack and avoid the Parser creation and item reparsing in most case.

nnethercote · 2025-03-07T11:12:51Z

From what I remember, stream_pretty_printing_compatibility_hack wasn't relevant to perf. Anyway, I think it makes more sense to dig into perf once Nonterminal is fully removed. We're currently at an awkward halfway state. E.g. making TokenKind impl Copy is a perf win.

@rustbot label: +perf-regression-triaged
@bors r=petrochenkov

bors · 2025-03-07T11:12:53Z

📌 Commit 3378ee1 has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2025-03-12T14:18:40Z

⌛ Testing commit 3378ee1 with merge aaa2d47...

bors · 2025-03-12T17:26:36Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing aaa2d47 to master...

github-actions · 2025-03-12T17:28:35Z

Post-merge analysis result

Test differences

x86_64-gnu
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 563): [missing] -> ignore
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 65): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1205): [missing] -> ignore
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3913): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 496): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 501): [missing] -> pass
- [ui] tests/ui/macros/macro-stmt-2.rs: [missing] -> pass
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 492): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1149): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 560): ignore -> [missing]
- (and 7 additional testss)
x86_64-gnu-nopt
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1205): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 501): [missing] -> pass
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3913): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 496): [missing] -> ignore
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 65): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 563): [missing] -> ignore
- [ui] tests/ui/macros/macro-stmt-2.rs: [missing] -> pass
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 492): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1149): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 491): pass -> [missing]
- (and 7 additional testss)
x86_64-gnu-llvm-19-3
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 65): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 501): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 563): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1205): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1149): [missing] -> ignore
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3913): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 492): [missing] -> pass
- [ui] tests/ui/macros/macro-stmt-2.rs: [missing] -> pass
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 496): [missing] -> ignore
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 64): ignore -> [missing]
- (and 7 additional testss)
x86_64-gnu-stable
- [ui] tests/ui/macros/macro-stmt-2.rs: [missing] -> pass
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 501): [missing] -> pass
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 496): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1149): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 563): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1205): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 492): [missing] -> pass
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3913): [missing] -> ignore
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 65): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1202): ignore -> [missing]
- (and 7 additional testss)
aarch64-gnu
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 492): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 563): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 496): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1149): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1205): [missing] -> ignore
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 65): [missing] -> ignore
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3913): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 501): [missing] -> pass
- [ui] tests/ui/macros/macro-stmt-2.rs: [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 560): ignore -> [missing]
- (and 7 additional testss)
x86_64-gnu-llvm-18-3
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 65): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 563): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 496): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 501): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1205): [missing] -> ignore
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3913): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1149): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 492): [missing] -> pass
- [ui] tests/ui/macros/macro-stmt-2.rs: [missing] -> pass
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3914): ignore -> [missing]
- (and 7 additional testss)
aarch64-apple
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1149): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 496): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 563): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1205): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 501): [missing] -> pass
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3913): [missing] -> ignore
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 65): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 492): [missing] -> pass
- [ui] tests/ui/macros/macro-stmt-2.rs: [missing] -> pass
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3914): ignore -> [missing]
- (and 7 additional testss)
i686-mingw-2
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 65): [missing] -> ignore
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3913): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 563): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 496): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 492): [missing] -> pass
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 501): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1149): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1205): [missing] -> ignore
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 64): ignore -> [missing]
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 560): ignore -> [missing]
- (and 6 additional testss)
i686-mingw-3
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1149): [missing] -> ignore
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3913): [missing] -> ignore
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 65): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 492): [missing] -> pass
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 496): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 501): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1205): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 563): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 495): ignore -> [missing]
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1146): ignore -> [missing]
- (and 6 additional testss)
i686-gnu-2
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 65): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 496): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 563): [missing] -> ignore
- compiler/rustc_parse/src/parser/expr.rs - parser::expr::CondChecker (line 3913): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1205): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1149): [missing] -> ignore
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 492): [missing] -> pass
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 501): [missing] -> pass
- compiler/rustc_hir_typeck/src/lib.rs - TupleArgumentsFlag (line 500): pass -> [missing]
- compiler/rustc_mir_transform/src/lib.rs - declare_passes (line 64): ignore -> [missing]
- (and 6 additional testss)

(and 6 additional diffs)

rust-timer · 2025-03-12T19:17:57Z

Finished benchmarking commit (aaa2d47): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	2.2%	[0.2%, 3.1%]	14
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[0.2%, 3.1%]	14

Max RSS (memory usage)

Results (primary -1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	1

Cycles

Results (primary 2.4%, secondary -3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.4%	[1.8%, 2.9%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-4.0%, -3.0%]	3
All ❌✅ (primary)	2.4%	[1.8%, 2.9%]	8

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.667s -> 779.458s (-0.03%)
Artifact size: 365.24 MiB -> 365.27 MiB (0.01%)

rustbot assigned petrochenkov Mar 6, 2025

nnethercote mentioned this pull request Mar 6, 2025

Remove Nonterminal and TokenKind::Interpolated #124141

Open

Urgau reviewed Mar 6, 2025

View reviewed changes

compiler/rustc_ast/src/lib.rs Outdated Show resolved Hide resolved

petrochenkov reviewed Mar 6, 2025

View reviewed changes

compiler/rustc_expand/src/proc_macro_server.rs Show resolved Hide resolved

compiler/rustc_parse/src/parser/stmt.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025

nnethercote force-pushed the rm-NtItem-NtStmt branch from d4aa97b to 541d42a Compare March 7, 2025 01:49

nnethercote added 3 commits March 7, 2025 14:51

Increase recursion_limit in numerous crates.

293fe0a

This is temporarily needed for `x doc compiler` to work. They can be removed once the `Nonterminal` is removed (rust-lang#124141).

More denesting of invisibly-delimited groups.

3378ee1

This time when converting them to proc-macro `Group` form.

nnethercote force-pushed the rm-NtItem-NtStmt branch from 541d42a to 3378ee1 Compare March 7, 2025 04:03

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 7, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025

Auto merge of rust-lang#138083 - nnethercote:rm-NtItem-NtStmt, r=<try>

17de919

Remove `NtItem` and `NtStmt` Another piece of rust-lang#124141. r? `@petrochenkov`

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 7, 2025

rustbot added the perf-regression-triaged The performance regression has been triaged. label Mar 7, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 7, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 12, 2025

bors merged commit aaa2d47 into rust-lang:master Mar 12, 2025
7 checks passed

rustbot added this to the 1.87.0 milestone Mar 12, 2025

This was referenced Mar 12, 2025

redesign stage 0 std #119899

Draft

Sized Hierarchy #137944

Open

nnethercote deleted the rm-NtItem-NtStmt branch March 12, 2025 22:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `NtItem` and `NtStmt` #138083

Remove `NtItem` and `NtStmt` #138083

nnethercote commented Mar 6, 2025

rustbot commented Mar 6, 2025

petrochenkov commented Mar 6, 2025

nnethercote commented Mar 7, 2025

nnethercote commented Mar 7, 2025

This comment has been minimized.

bors commented Mar 7, 2025

bors commented Mar 7, 2025

This comment has been minimized.

rust-timer commented Mar 7, 2025

petrochenkov commented Mar 7, 2025

nnethercote commented Mar 7, 2025

bors commented Mar 7, 2025

bors commented Mar 12, 2025

bors commented Mar 12, 2025

github-actions bot commented Mar 12, 2025

rust-timer commented Mar 12, 2025

Remove NtItem and NtStmt #138083

Remove NtItem and NtStmt #138083

Conversation

nnethercote commented Mar 6, 2025

rustbot commented Mar 6, 2025

petrochenkov commented Mar 6, 2025

nnethercote commented Mar 7, 2025

nnethercote commented Mar 7, 2025

This comment has been minimized.

bors commented Mar 7, 2025

bors commented Mar 7, 2025

This comment has been minimized.

rust-timer commented Mar 7, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

petrochenkov commented Mar 7, 2025

nnethercote commented Mar 7, 2025

bors commented Mar 7, 2025

bors commented Mar 12, 2025

bors commented Mar 12, 2025

github-actions bot commented Mar 12, 2025

Test differences

rust-timer commented Mar 12, 2025

Overall result: ❌ regressions - please read the text below

Remove `NtItem` and `NtStmt` #138083

Remove `NtItem` and `NtStmt` #138083