-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #138279
Rollup of 7 pull requests #138279
Conversation
Apply dllimport in ThinLTO This partially reverts rust-lang#103353 by properly applying `dllimport` if `-Z dylib-lto` is passed. That PR should probably fully be reverted as it looks quite sketchy. We don't know locally if the entire crate graph would be statically linked. This should hopefully be sufficient to make ThinLTO work for rustc on Windows. r? ``@wesleywiser`` --- Edit: This PR is changed to just generally revert rust-lang#103353.
Move `fs` into `sys` Move platform definitions of `fs` into `std::sys`, as part of rust-lang#117276. cc `@joboet`
Use `disjoint_bitor` inside `borrowing_sub` This makes the definition of `borrowing_sub` consistent with that of `carrying_add`.
Windows: Don't link std (and run-make) against advapi32, except on win7 Std no longer depends on any functionality provided by advapi32, so we can remove it from the list of external libraries we link against. Except, the win7 targets do still rely on advapi32-provided functionality. This PR therefore moves linking against it to only occur on win7 targets, so that no new uses of it slip in without being noticed.
…nszelmann Continue to check attr if meet empty repr for adt Fixes rust-lang#138241 Returning while checking ReprEmpty results in missing the check for the next repr
…ouxu Fix `repr128-dwarf` test The test now correctly ignores enums from `std`. Fixes rust-lang#138254 Unblocks rust-lang#138200
…enton Lazy load NtOpenFile for UWP Lazily load `NtOpenFile` to allow libraries targeting UWP to build and link. Fixes rust-lang#138257 . r? `@ChrisDenton`
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot)
|
📌 Perf builds for each rolled up PR:
previous master: 385970f0c1 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (3ea711f): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -2.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -8.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.0%, secondary -0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 769.881s -> 770.102s (0.03%) |
Successful merges:
fs
intosys
#137650 (Movefs
intosys
)disjoint_bitor
insideborrowing_sub
#138228 (Usedisjoint_bitor
insideborrowing_sub
)repr128-dwarf
test #138263 (Fixrepr128-dwarf
test)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup