Replace no_elf_tls with target_thread_local #30678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! Looks like I forgot to cover scoped TLS when I changed it. Could you leave around the |
|
I added the |
bors
added a commit
that referenced
this pull request
Jan 12, 2016
I also re-enabled the use of `#[thread_local]` on AArch64. It was originally disabled in the PR that introduced AArch64 (#19790), but the reasons for this were not explained. `#[thread_local]` seems to work fine in my tests on AArch64, so I don't think this should be an issue. cc @alexcrichton @akiss77
rillian
added a commit
to rillian/rust
that referenced
this pull request
May 2, 2017
Support for disabling ELF-style thread local storage in the standard library at configure time was removed in pulls rust-lang#30417 and rust-lang#30678, in favour of a member in the TargetOptions database. The new method respects MACOSX_DEPLOYMENT_TARGET on macOS, addressing the original use case for this configure option. However, those commits left the configure option itself in place. It's no longer referenced anywhere and can be removed.
bors
added a commit
that referenced
this pull request
May 4, 2017
Remove obsolete --disable-elf-tls configure switch. Support for disabling ELF-style thread local storage in the standard library at configure time was removed in pulls #30417 and #30678, in favour of a member in the TargetOptions database. The new mentod respects MACOSX_DEPLOYMENT_TARGET on macOS, addressing the original use case for this configure optionl However, those commits left the configure option itself in place. It's no longer referenced anywhere and can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30417 replaced the
--disable-elf-tlsconfigure option with acfg(target_thread_local)target attribute forthread_local!, butscoped_thread_local!still used the oldcfg(no_elf_tls)option. This PR changesscoped_thread_local!to usecfg(target_thread_local)to determine whether the#[thread_local]attribute is available. It also removes the--disable-elf-tlsconfigure option since it is no longer used.I also re-enabled the use of
#[thread_local]on AArch64. It was originally disabled in the PR that introduced AArch64 (#19790), but the reasons for this were not explained.#[thread_local]seems to work fine in my tests on AArch64, so I don't think this should be an issue.cc @alexcrichton @akiss77