Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore tests that fail on stage1 #43744

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Ignore tests that fail on stage1 #43744

merged 1 commit into from
Aug 11, 2017

Conversation

MaloJaffre
Copy link
Contributor

That makes ./x.py test --stage 1 work on x86_64-unknown-linux-gnu.

@MaloJaffre
Ignore tests that fail on stage1
cf7f305 
That makes ./x.py test --stage 1 work on x86_64-unknown-linux-gnu.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aidanhs aidanhs assigned alexcrichton and unassigned nikomatsakis Aug 10, 2017
@aidanhs
Copy link
Member

aidanhs commented Aug 10, 2017

Thanks for the PR @MaloJaffre! We'll check in now and again to make sure @alexcrichton or another reviewer gets to this soon.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Aug 10, 2017

📌 Commit cf7f305 has been approved by Mark-Simulacrum

@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 10, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 11, 2017
@GuillaumeGomez
Rollup merge of rust-lang#43744 - MaloJaffre:stage1-test, r=Mark-Simu…
2ad3baa 
…lacrum

Ignore tests that fail on stage1

That makes `./x.py test --stage 1` work on `x86_64-unknown-linux-gnu`.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 11, 2017
Merged
bors added a commit that referenced this pull request Aug 11, 2017
@bors
Auto merge of #43800 - GuillaumeGomez:rollup, r=GuillaumeGomez
59675d2 
Rollup of 18 pull requests

- Successful merges: #43176, #43632, #43650, #43712, #43715, #43721, #43739, #43741, #43744, #43747, #43752, #43760, #43773, #43779, #43783, #43791, #43793, #43795
- Failed merges:
MaloJaffre added a commit to MaloJaffre/rust that referenced this pull request Aug 11, 2017
@MaloJaffre
Rollup merge of rust-lang#43744 - MaloJaffre:stage1-test, r=Mark-Simu…
3dabf4f 
…lacrum

Ignore tests that fail on stage1

That makes `./x.py test --stage 1` work on `x86_64-unknown-linux-gnu`.
@MaloJaffre MaloJaffre mentioned this pull request Aug 11, 2017
Closed
@bors bors merged commit cf7f305 into rust-lang:master Aug 11, 2017
@MaloJaffre MaloJaffre deleted the stage1-test branch August 13, 2017 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MaloJaffre @rust-highfive @aidanhs @Mark-Simulacrum @bors @alexcrichton @nikomatsakis