Add unstable 128 bit SipHash version for internal use in the compiler. #45237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion in #41215 seems to show that a 128 bit SipHash is the best compromise between hash quality and performance. This PR adds an unstable, hidden 128 bit variant to the SipHash implementation in libstd for use solely within the compiler. A future PR would then switch
StableHasher
to use this implementation.What do you say, @rust-lang/libs? Acceptable?
r? @alexcrichton