rustc: prefer ParamEnvAnd and LayoutCx over tuples for LayoutOf. #47915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 9c3dc7e has been approved by |
nikomatsakis
added
S-waiting-on-bors
|
@bors p=1 (move more complex PRs forward) |
|
⌛ Testing commit 9c3dc7e with merge 0e1741ed4f8b459407718a6f1babdbbb0fc247ce... |
|
💔 Test failed - status-appveyor |
|
@bors retry Is this a known timeout issue? |
bors
added a commit
that referenced
this pull request
Feb 4, 2018
rustc: prefer ParamEnvAnd and LayoutCx over tuples for LayoutOf. This PR provides `tcx.layout_of(param_env.and(ty))` as the idiomatic replacement for the existing `(tcx, param_env).layout_of(ty)` and removes fragile (coherence-wise) layout-related tuple impls. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
|
(BTW, the previous timeout was due to 1h 42m spent on cloning binaryen. ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides
tcx.layout_of(param_env.and(ty))as the idiomatic replacement for the existing(tcx, param_env).layout_of(ty)and removes fragile (coherence-wise) layout-related tuple impls.r? @nikomatsakis