libtest: Replace panics with error messages #47986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Kimundi (rust_highfive has picked a reviewer for you, use r? to override) |
src/libtest/lib.rs
Outdated
| Err(e) => panic!("io error when running tests: {:?}", e), | ||
| Err(e) => { | ||
| eprintln!("error: io error when listing tests: {:?}", e); | ||
| ::std::process::exit(101); |
There was a problem hiding this comment.
Let's import std::process to make these a little cleaner.
Gilnaa
force-pushed
the
libtest_relaxed
branch
from
0d653f7 to
61ff3ba
Compare
|
Refactored as you suggested. The error code is the same as what have been used elsewhere in the file; is there some sort of standard? |
kennytm
added
the
S-waiting-on-review
|
Not really. @bors r+ |
|
📌 Commit 61ff3ba has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 6, 2018
…lacrum libtest: Replace panics with error messages This replaces explicit panics on failures in libtest with prints to stderr. Where "failures" == CLI argument parsing and such Before: ``` $ ./foo-stable --not-an-option thread 'main' panicked at '"Unrecognized option: \'not-an-option\'"', libtest/lib.rs:251:27 note: Run with `RUST_BACKTRACE=1` for a backtrace. ``` After: ``` $ ./foo-nightly --not-an-option error: Unrecognized option: 'not-an-option' ```
bors
added a commit
that referenced
this pull request
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces explicit panics on failures in libtest with prints to stderr.
Where "failures" == CLI argument parsing and such
Before:
After: