Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make metadata references Send + Sync #48690

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Make metadata references Send + Sync #48690

merged 1 commit into from
Mar 8, 2018

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 3, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2018
nikic
nikic reviewed Mar 3, 2018
View reviewed changes
src/librustc_data_structures/owning_ref/mod.rs Outdated
@@ -289,10 +290,20 @@ pub unsafe trait IntoErased<'a> {
fn into_erased(self) -> Self::Erased;
}

/// Helper trait for erasing the concrete type of what an owner derferences to,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/derferences/dereferences

@michaelwoerister
Copy link
Member

Thanks, @Zoxc! Looks good to me!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 5, 2018

📌 Commit a483a2f has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2018
@Zoxc Zoxc force-pushed the metadata-send-sync branch from a483a2f to 62089c3 Compare March 7, 2018 00:57
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 7, 2018

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented Mar 7, 2018

📌 Commit 62089c3 has been approved by michaelwoerister

@alexcrichton alexcrichton merged commit 62089c3 into rust-lang:master Mar 8, 2018
@Zoxc Zoxc deleted the metadata-send-sync branch March 14, 2018 16:39
@aturon aturon mentioned this pull request Aug 16, 2019
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zoxc @michaelwoerister @bors @nikic @alexcrichton @rust-highfive