Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize IP associated constants #53213

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Stabilize IP associated constants #53213

merged 1 commit into from
Aug 21, 2018

Conversation

tmccombs
Copy link
Contributor

@tmccombs tmccombs commented Aug 9, 2018

Fixes #44582

@rust-highfive
Copy link
Collaborator

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2018
kennytm
kennytm reviewed Aug 9, 2018
View reviewed changes
src/libstd/net/ip.rs Outdated
#[unstable(feature = "ip_constructors",
reason = "requires greater scrutiny before stabilization",
issue = "44582")]
#[stable(feature = "ip_constructors", since = "1.29.0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should be 1.30.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. Is there an easy way to see what the current nightly version is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmccombs http://play.rust-lang.org/ will show the nightly version in use if you open the channel dropdown menu. But also, it's basically always current stable +2 versions.

@kennytm kennytm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Aug 9, 2018
@tmccombs tmccombs force-pushed the stable-ipconstructors branch from 5f6e174 to e6244e5 Compare August 15, 2018 05:43
@KodrAus
Copy link
Contributor

KodrAus commented Aug 19, 2018

Thanks @tmccombs!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 19, 2018

📌 Commit e6244e5 has been approved by KodrAus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2018
@bors
Copy link
Contributor

bors commented Aug 20, 2018

⌛ Testing commit e6244e5 with merge fdef814b12b783e4924a8422dce76a125d617c97...

@bors
Copy link
Contributor

bors commented Aug 20, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 20, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-aux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:40:44] 
[01:40:44] testing https://github.com/BurntSushi/xsv
[01:40:44] Initialized empty Git repository in /checkout/obj/build/ct/xsv/.git/
[01:40:44] fatal: Could not parse object '66956b6bfd62d6ac767a6b6499c982eae20a2c9f'.
[01:41:04] fatal: unable to access 'https://github.com/BurntSushi/xsv/': Could not resolve host: github.com
[01:41:04] thread 'main' panicked at 'assertion failed: status.success()', tools/cargotest/main.rs:128:13
[01:41:04] 
[01:41:04] 
[01:41:04] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/cargotest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/ct"
[01:41:04] expected success, got: exit code: 101
[01:41:04] expected success, got: exit code: 101
[01:41:04] 
[01:41:04] 
[01:41:04] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/test/pretty src/test/run-pass/pretty src/test/run-fail/pretty src/test/run-pass-valgrind/pretty src/test/run-pass-fulldeps/pretty src/test/run-fail-fulldeps/pretty src/tools/cargo src/tools/cargotest
[01:41:04] Build completed unsuccessfully in 0:42:49
[01:41:04] make: *** [check-aux] Error 1
[01:41:04] Makefile:60: recipe for target 'check-aux' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:20f39808
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:0d0c2d64:start=1534746832663994656,finish=1534746832672208169,duration=8213513
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:08342d3a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0be99614
travis_time:start:0be99614
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:10be63a0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@tmccombs
Copy link
Contributor Author

The failed build looks like a hickup with accessing github.com

@kennytm
Copy link
Member

kennytm commented Aug 20, 2018

@bors retry travis-ci/travis-ci#9696

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2018
@kennytm
Copy link
Member

kennytm commented Aug 20, 2018

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Aug 20, 2018
@kennytm
Rollup merge of rust-lang#53213 - tmccombs:stable-ipconstructors, r=K…
fa3d56a 
…odrAus

Stabilize IP associated constants

Fixes rust-lang#44582
@kennytm kennytm mentioned this pull request Aug 20, 2018
Merged
bors added a commit that referenced this pull request Aug 21, 2018
@bors
Auto merge of #53530 - kennytm:rollup, r=kennytm
9f9f2c0 
Rollup of 17 pull requests

Successful merges:

 - #53030 (Updated RELEASES.md for 1.29.0)
 - #53104 (expand the documentation on the `Unpin` trait)
 - #53213 (Stabilize IP associated constants)
 - #53296 (When closure with no arguments was expected, suggest wrapping)
 - #53329 (Replace usages of ptr::offset with ptr::{add,sub}.)
 - #53363 (add individual docs to `core::num::NonZero*`)
 - #53370 (Stabilize macro_vis_matcher)
 - #53393 (Mark libserialize functions as inline)
 - #53405 (restore the page title after escaping out of a search)
 - #53452 (Change target triple used to check for lldb in build-manifest)
 - #53462 (Document Box::into_raw returns non-null ptr)
 - #53465 (Remove LinkMeta struct)
 - #53492 (update lld submodule to include RISCV patch)
 - #53496 (Fix typos found by codespell.)
 - #53521 (syntax: Optimize some literal parsing)
 - #53540 (Moved issue-53157.rs into src/test/ui/consts/const-eval/)
 - #53551 (Avoid some Place clones.)

Failed merges:

r? @ghost
@bors bors merged commit e6244e5 into rust-lang:master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@faern faern faern left review comments

Assignees

@KodrAus KodrAus

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tmccombs @rust-highfive @KodrAus @bors @kennytm @faern