Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit impls referencing errors to overlap #64474

Merged
merged 1 commit into from
Sep 15, 2019

Conversation

Mark-Simulacrum
Copy link
Member

Fixes #43400; previously this would emit an overlapping impls error, but no longer does.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2019
@Mark-Simulacrum
Copy link
Member Author

Both comments resolved.

@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 15, 2019

📌 Commit 959c710 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2019
@bors
Copy link
Collaborator

bors commented Sep 15, 2019

⌛ Testing commit 959c710 with merge 96d07e0...

bors added a commit that referenced this pull request Sep 15, 2019
…asper

Permit impls referencing errors to overlap

Fixes #43400; previously this would emit an overlapping impls error, but no longer does.
@bors
Copy link
Collaborator

bors commented Sep 15, 2019

☀️ Test successful - checks-azure
Approved by: matthewjasper
Pushing 96d07e0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 15, 2019
@bors bors merged commit 959c710 into rust-lang:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spurious coherence error using error-chain with nonexistent type
6 participants