Bugfix for license check

[gilescope]

cargo fmt would only work if you were in the root dir before if a license check template was set.
(as otherwise it would not find the template.)

• is there a better way of doing this? I don't really like to mutate global state such as the current dir.

[rust-highfive]

Some changes occurred in src/tools/rustfmt.

cc @calebcartwright

[rust-highfive]

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

[gilescope]

(As mentioned as an issue in rust-lang/rustfmt#3352 )

[calebcartwright]

Thank you but rustfmt PRs need to be opened against the rustfmt repo as opposed to updating the subtree here.

[gilescope]

ah ok. I thought maybe I needed to do it this way as the rustfmt repo seemed dependent upon the rustc one (E.g. dependencies on the _ast crates). Will test via rustc repo and commit back to the main rustfmt repo.

…

On Fri, 30 Jul 2021 at 14:21, Caleb Cartwright ***@***.***> wrote: Thank you but rustfmt PRs need to be opened against the rustfmt repo as opposed to updating the subtree here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#87627 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGEJCBJVY3VKTIZD43OGRTT2KROJANCNFSM5BIOODRA> .

[calebcartwright]

I thought maybe I needed to do it this way as the rustfmt repo
seemed dependent upon the rustc one (E.g. dependencies on the _ast crates).

No worries. Tool development happens in the respective repos for all tools that are subtrees or sumbodules. Tool changes then get pulled into the rustc repo at regular intervals and/or as needed to address specific issues. The tool subtrees should only be updated directly when strictly necessary with minimal changes required as part of changes tot rustc, such as AST changes that are breaking to the tool.

This PR should be closed and submitted to rust-lang/rustfmt instead

[gilescope]

Thumbsup, will do

…

On Fri, 30 Jul 2021 at 18:09, Caleb Cartwright ***@***.***> wrote: I thought maybe I needed to do it this way as the rustfmt repo seemed dependent upon the rustc one (E.g. dependencies on the _ast crates). No worries. Tool development happens in the respective repos for all tools that are subtrees or sumbodules. Tool changes then get pulled into the rustc repo at regular intervals and/or as needed to address specific issues. The tool subtrees should only be updated directly when strictly necessary with minimal changes required as part of changes tot rustc, such as AST changes that are breaking to the tool. This PR should be closed and submitted to rust-lang/rustfmt instead — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#87627 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGEJCCB5YR6ASQ4KHEN55LT2LMD3ANCNFSM5BIOODRA> .

[Mark-Simulacrum]

Thanks. Closing as it seems this will be refiled on rustfmt directly.