use enumerate in place of 'for ti in range(i, tokens.len()) ...' #9030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -304,8 +304,8 @@ impl Pattern { | |||
| && is_sep(prev_char.unwrap_or_default('/'))) | |||
| }; | |||
|
|
|||
| for ti in range(i, self.tokens.len()) { | |||
| match self.tokens[ti] { | |||
| for (ti, token) in self.tokens.slice_from(i).iter().enumerate() { | |||
There was a problem hiding this comment.
Doesn't this mean that ti_new == ti_old - i (i.e. it's a different number)?
There was a problem hiding this comment.
Good catch! Updated the place where ti is used.
bors
added a commit
that referenced
this pull request
Sep 7, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2022
…ip1995 Remove `cargo_dev` dependency changelog: none Sorry about that 😅. r? `@flip1995`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.