-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't emit shared files when scraping examples from dependencies in Rustdoc #92146
Conversation
This seems kind of hacky ... eventually I'd like to separate actually generating the HTML from creating the Context. But this is reasonable as a short term fix. r=me if you don't feel like refactoring half of rustdoc 😁 @bors delegate=willcrichton |
✌️ @willcrichton can now approve this pull request |
@bors r=jyn514 |
📌 Commit b7de797 has been approved by |
⌛ Testing commit b7de797 with merge 695c53cca37057a9e61db16840932e68adf7acf6... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry Windows test_interior_nul issue |
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#88858 (Allow reverse iteration of lowercase'd/uppercase'd chars) - rust-lang#91544 (Fix duplicate derive clone suggestion) - rust-lang#92026 (Add some JSDoc comments to rustdoc JS) - rust-lang#92117 (kmc-solid: Add `std::sys::solid::fs::File::read_buf`) - rust-lang#92139 (Change Backtrace::enabled atomic from SeqCst to Relaxed) - rust-lang#92146 (Don't emit shared files when scraping examples from dependencies in Rustdoc) - rust-lang#92208 (Quote bat script command line) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This PR fixes #91605. The issue is that
Context::init
gets called when scraping dependencies. By default, just callinginit
calls intowrite_shared
andbuild_index
which register the scraped crate into a list that later gets used for the Rustdoc sidebar. The fix is to ensure thatwrite_shared
is not called when scraping.r? @jyn514