Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Check previous impossible preds implementation #96382

Conversation

compiler-errors
Copy link
Member

Check perf for #95398 before I pushed a rewrite this morning

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 25, 2022
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 25, 2022
@bors
Copy link
Contributor

bors commented Apr 25, 2022

⌛ Trying commit ed81aa61ef6f83324da3220c5c965432cae52bda with merge 5798f00564fa7d7b4d621fef8ef2e55dcce8ab68...

@bors
Copy link
Contributor

bors commented Apr 25, 2022

☀️ Try build successful - checks-actions
Build commit: 5798f00564fa7d7b4d621fef8ef2e55dcce8ab68 (5798f00564fa7d7b4d621fef8ef2e55dcce8ab68)

@rust-timer
Copy link
Collaborator

Queued 5798f00564fa7d7b4d621fef8ef2e55dcce8ab68 with parent 1f631e8, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5798f00564fa7d7b4d621fef8ef2e55dcce8ab68): comparison url.

Summary:

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 20 10 0 0 20
mean2 0.4% 0.9% N/A N/A 0.4%
max 0.8% 4.4% N/A N/A 0.8%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 25, 2022
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 27, 2022
@bors
Copy link
Contributor

bors commented Apr 27, 2022

⌛ Trying commit 73b8283d1acceb726999f6c90bdddc20a7044eb2 with merge 4193e323da81209cd0b520a52cb52ec215679775...

@rust-log-analyzer

This comment was marked as resolved.

@bors
Copy link
Contributor

bors commented Apr 27, 2022

☀️ Try build successful - checks-actions
Build commit: 4193e323da81209cd0b520a52cb52ec215679775 (4193e323da81209cd0b520a52cb52ec215679775)

@rust-timer
Copy link
Collaborator

Queued 4193e323da81209cd0b520a52cb52ec215679775 with parent a719718, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4193e323da81209cd0b520a52cb52ec215679775): comparison url.

Summary:

  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 2 7 0 0 2
mean2 0.4% 0.3% N/A N/A 0.4%
max 0.4% 0.4% N/A N/A 0.4%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 27, 2022
@compiler-errors compiler-errors force-pushed the test-perf-impossible-preds branch from 6975dc7 to e230acf Compare April 27, 2022 05:17
@compiler-errors compiler-errors force-pushed the test-perf-impossible-preds branch from e230acf to 32601a2 Compare April 27, 2022 05:17
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 27, 2022
@bors
Copy link
Contributor

bors commented Apr 27, 2022

⌛ Trying commit 32601a2 with merge 1e9960415a67acd0b77f4240e738df9bef5d54d0...

@bors
Copy link
Contributor

bors commented Apr 27, 2022

☀️ Try build successful - checks-actions
Build commit: 1e9960415a67acd0b77f4240e738df9bef5d54d0 (1e9960415a67acd0b77f4240e738df9bef5d54d0)

@rust-timer
Copy link
Collaborator

Queued 1e9960415a67acd0b77f4240e738df9bef5d54d0 with parent 99b70ee, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1e9960415a67acd0b77f4240e738df9bef5d54d0): comparison url.

Summary:

  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regressions found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 6 8 2 0 8
mean2 0.4% 0.4% -0.7% N/A 0.1%
max 0.5% 1.2% -0.9% N/A -0.9%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 27, 2022
@compiler-errors compiler-errors deleted the test-perf-impossible-preds branch August 11, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants